Fix nullable tests#3637
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes build failures in test projects related to nullable reference type usage, addressing issue #3636 by aligning test code with each test project’s nullable configuration.
Changes:
- Removed nullable reference annotations (e.g.,
string?) fromService.Testsunit tests to match that project’s nullable-disabled compilation settings. - Updated
Cli.Testshelper entity creation to avoid passingnullinto non-nullableEntityGraphQLOptionsconstructor parameters. - Adjusted a
Cli.Testsend-to-end assertion to satisfy nullable analysis forDataSource.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Service.Tests/UnitTests/SqlQueryExecutorUnitTests.cs | Removes nullable reference annotations in test parameters/helpers to avoid nullable-annotation compilation warnings/errors. |
| src/Service.Tests/UnitTests/RequestParserUnitTests.cs | Removes nullable reference annotations in local/test parameters consistent with nullable-disabled test project settings. |
| src/Service.Tests/Configuration/RuntimeConfigLoaderTests.cs | Removes nullable reference annotations for env-var locals to avoid nullable-annotation compilation warnings/errors. |
| src/Cli.Tests/ValidateConfigTests.cs | Replaces null GraphQL singular/plural with string.Empty to satisfy non-nullable EntityGraphQLOptions constructor. |
| src/Cli.Tests/EndToEndTests.cs | Uses null-forgiving operator for DataSource when asserting connection string under nullable-enabled compilation. |
Aniruddh25
approved these changes
May 26, 2026
anushakolan
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
This change solves issue #3636
What is this change?
?symbol from the testing variables in order to allow the project to build properly inside the pipelineHow was this tested?
Manually ran the pipeline to ensure that it builds appropriately.
Sample Request(s)
N/A