Skip to content

Fix nullable tests#3637

Merged
RubenCerna2079 merged 1 commit into
release/2.0from
dev/rubencerna/fix-tests-release2.0
May 26, 2026
Merged

Fix nullable tests#3637
RubenCerna2079 merged 1 commit into
release/2.0from
dev/rubencerna/fix-tests-release2.0

Conversation

@RubenCerna2079
Copy link
Copy Markdown
Contributor

@RubenCerna2079 RubenCerna2079 commented May 26, 2026

Why make this change?

This change solves issue #3636

What is this change?

  • Removed the ? symbol from the testing variables in order to allow the project to build properly inside the pipeline

How was this tested?

  • Integration Tests
  • Unit Tests
  • Manual Tests

Manually ran the pipeline to ensure that it builds appropriately.

Sample Request(s)

N/A

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes build failures in test projects related to nullable reference type usage, addressing issue #3636 by aligning test code with each test project’s nullable configuration.

Changes:

  • Removed nullable reference annotations (e.g., string?) from Service.Tests unit tests to match that project’s nullable-disabled compilation settings.
  • Updated Cli.Tests helper entity creation to avoid passing null into non-nullable EntityGraphQLOptions constructor parameters.
  • Adjusted a Cli.Tests end-to-end assertion to satisfy nullable analysis for DataSource.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Service.Tests/UnitTests/SqlQueryExecutorUnitTests.cs Removes nullable reference annotations in test parameters/helpers to avoid nullable-annotation compilation warnings/errors.
src/Service.Tests/UnitTests/RequestParserUnitTests.cs Removes nullable reference annotations in local/test parameters consistent with nullable-disabled test project settings.
src/Service.Tests/Configuration/RuntimeConfigLoaderTests.cs Removes nullable reference annotations for env-var locals to avoid nullable-annotation compilation warnings/errors.
src/Cli.Tests/ValidateConfigTests.cs Replaces null GraphQL singular/plural with string.Empty to satisfy non-nullable EntityGraphQLOptions constructor.
src/Cli.Tests/EndToEndTests.cs Uses null-forgiving operator for DataSource when asserting connection string under nullable-enabled compilation.

Comment thread src/Cli.Tests/EndToEndTests.cs
@RubenCerna2079 RubenCerna2079 moved this from Todo to Review In Progress in Data API builder May 26, 2026
@RubenCerna2079 RubenCerna2079 linked an issue May 26, 2026 that may be closed by this pull request
@RubenCerna2079 RubenCerna2079 enabled auto-merge (squash) May 26, 2026 22:27
@RubenCerna2079 RubenCerna2079 merged commit 36a5fea into release/2.0 May 26, 2026
15 checks passed
@RubenCerna2079 RubenCerna2079 deleted the dev/rubencerna/fix-tests-release2.0 branch May 26, 2026 22:43
@github-project-automation github-project-automation Bot moved this from Review In Progress to Done in Data API builder May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Fix Nullable Tests Failing

4 participants