Skip to content

Added new variable which specifies which container should be deployed#79

Open
jkszymans wants to merge 3 commits into
Azure:mainfrom
jkszymans:feature/container-image-name-var
Open

Added new variable which specifies which container should be deployed#79
jkszymans wants to merge 3 commits into
Azure:mainfrom
jkszymans:feature/container-image-name-var

Conversation

@jkszymans

Copy link
Copy Markdown

No description provided.

@crostonj crostonj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Comment thread action.yml Outdated
@Bastien-Brd

Copy link
Copy Markdown

👍 I came here for this same change, will this ever be merged?

Is this Github Action abandoned?

@jkszymans

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@jkszymans

Copy link
Copy Markdown
Author

I think it is ready to go now

@pether-b

pether-b commented Aug 2, 2024

Copy link
Copy Markdown

I only found a typo in this PR but don't recall why I was looking at it and don't think I'm qualified to review it :)

@jolguk

jolguk commented Sep 11, 2024

Copy link
Copy Markdown

Hi. Is this going to be merged please @pether-b @daniel-bishop-conductiv Thank you.

@pether-b

Copy link
Copy Markdown

I approved now, first by mistake with my other account and then with my regular one. I don't think it helps though, as someone with write access has to approve before it can be merged.

@vandathron

Copy link
Copy Markdown

Any update on this please?

@erikbrgn

erikbrgn commented Apr 7, 2025

Copy link
Copy Markdown

Am I wrong in thinking that this PR doesn't solve the issue fully?

I'm pretty sure that the containerName input has to be used in the setupContainerAppProperties function (

private static setupContainerAppProperties() {
) before this PR can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants