ZZZ#628
Draft
anporumb wants to merge 11 commits into
Draft
Conversation
Pin deps/c-build-tools and the GitHub-resource ref in build/devops_gated.yml to Azure/c-build-tools@3849e4e to validate the new MAX_STAGE infrastructure (default UNIT_TESTS, no run_arm64_tests knob, ARM64 leg becomes blocking and runs unit tests). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
Pin deps/c-build-tools and the GitHub-resource ref in build/devops_gated.yml to Azure/c-build-tools@14149d5 to validate appverif.exe is now found via discover_native_tools.yml on the build pools. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ctest now filters to _ut tests on ARM64 when MAX_STAGE=UNIT_TESTS so int tests like external_command_helper_int do not run on ARM64. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pin c-build-tools to the new commit that adds Windows Kits Debuggers paths to the appverif probe (the new buildpool agents ship appverif.exe under C:\Program Files (x86)\Windows Kits\10\Debuggers\<arch>\), makes the probe architecture-aware, and fixes the hardcoded VS 2022 Enterprise ctest path the helper was still using. The previous smoke against 14149d5 + a23f683 (pinned here before this bump) still showed the AppVerifier gate skipping silently because the probe missed the Windows Kits location. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ilter fix) Pin c-build-tools to the new commit that: * makes appverif.exe a mandatory pool prerequisite (discover_native_tools.yml aborts the job with ##[error] + exit 1 if not located - no more silent skip with empty $(appverifPath)); * simplifies appverifier_ctest_tests_helper.ps1 to a pure consumer of the discovered $(appverifPath) / $(ctestPath) (no env / PATH / hardcoded-VS fallbacks, all of which were the "flakiness" being papered over); * fixes the ARM64+UNIT_TESTS ctest filter so it excludes _int|_perf|_e2e instead of including only _ut$. The previous include-based filter matched zero tests in c-build-tools' own gate (validate_*_test, RUN_REALS_CHECK_TEST do not end in _ut), tripping --no-tests=error and reddening the gate. The new exclude-based filter keeps the int/perf/e2e- off-ARM64 intent while still admitting any non-_ut-suffixed test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pin c-build-tools to the new commit that adds Sysnative to the appverif candidate list. This unbreaks detection on the ARM64 hosted pool, where the agent runs as x86 under emulation and the previous System32 probe got WOW64-redirected to SysWOW64 (which has no ARM64 binary). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pin c-build-tools to the new commit on anporumb/buildpool that adds per-arch MAX_STAGE override (MAX_STAGE_x64 / MAX_STAGE_arm64 / MAX_STAGE_x86) and strictifies UNIT_TESTS to exclude _int / _perf / _e2e categories on every architecture (previously ARM64-only). This repo's gate currently runs int / perf / e2e tests on x64 under the old loose UNIT_TESTS semantic; add MAX_STAGE_x64: ALL to preserve that coverage under the new contract. ARM64 stays at the default UNIT_TESTS (now strict). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…lidator) The previous c-build-tools commit (3a6192f) added MAX_STAGE_x64 etc. with a values: enum that included an empty string, which ADO's pipeline validator rejects. 26190c6 drops the values: enum entirely. Repointing the smoke pin so the gate can validate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…AX_STAGE knob) Pin c-build-tools to the new commit on anporumb/buildpool that removes the consumer-facing MAX_STAGE / MAX_STAGE_<arch> parameters from build_all_flavors.yml. The per-architecture test stage is now hardcoded build-infra policy: ARM64 -> UNIT_TESTS, x64/x86 -> ALL. The MAX_STAGE_x64: ALL line that was added in the previous smoke commit is removed in this commit because the parameter no longer exists. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…iscovery summary) Pin c-build-tools to the new commit on anporumb/buildpool that drops the unneeded x86 branch from the per-arch matrix conditional, removes a couple of stale comments, and adds appverif to the discover_native_tools summary listing. Functionally equivalent to e0bc7a1; just cleanup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… set)
Pin c-build-tools to the new commit on anporumb/buildpool that disables
ctest --no-tests=error when the MAX_STAGE=UNIT_TESTS exclude filter is
active. This unblocks repos like macro-utils-c that only have _int tests
and would otherwise see ctest exit 8 ("No tests were found!!!") on the
ARM64 leg after the strict UNIT_TESTS filter excludes everything.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin deps/c-build-tools and the GitHub-resource ref in build/devops_gated.yml to Azure/c-build-tools@3849e4e to validate the new MAX_STAGE infrastructure (default UNIT_TESTS, no run_arm64_tests knob, ARM64 leg becomes blocking and runs unit tests).