Skip to content

fixing the getparticipant issue #47538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
v-dharmarajv wants to merge 1 commit into
base: users/v-dharmarajv/ga7Changes
Choose a base branch
from
Open

fixing the getparticipant issue #47538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions ...n/azure-communication-callautomation/azure/communication/callautomation/_shared/policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,33 +63,6 @@ def _sign_request(self, request: PipelineRequest) -> None:
if parsed_url.query:
query_url += "?" + parsed_url.query

# Need URL() to get a correct encoded key value, from "%3A" to ":", when transport is in type AioHttpTransport.
# There's a similar scenario in azure-storage-blob and azure-appconfiguration, the check logic is from there.
try:
from yarl import URL
from azure.core.pipeline.transport import ( # pylint:disable=non-abstract-transport-import
AioHttpTransport,
)

if (
isinstance(request.context.transport, AioHttpTransport)
or isinstance(
getattr(request.context.transport, "_transport", None),
AioHttpTransport,
)
or isinstance(
getattr(
getattr(request.context.transport, "_transport", None),
"_transport",
None,
),
AioHttpTransport,
)
):
query_url = str(URL(query_url))
except (ImportError, TypeError):
pass

if self._decode_url:
query_url = unquote(query_url)

Expand Down
4 changes: 0 additions & 4 deletions sdk/communication/azure-communication-callautomation/tests/test_e2e_callautomation_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,6 @@ def test_add_participant_then_cancel_request(self):
self.terminate_call(unique_id)
return

@pytest.mark.skip(
reason="""Playback fails for same event type triggered and test recording code
takes the event type has the dictionary it fails to recording call connected event for the connect api"""
)
@recorded_by_proxy
def test_create_VOIP_call_and_connect_call_then_hangup(self):
# try to establish the call
Expand Down
4 changes: 0 additions & 4 deletions ...nication/azure-communication-callautomation/tests/test_e2e_callautomation_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,6 @@ async def test_add_participant_then_cancel_request_async(self):

await self.terminate_call(call_connection_id)

@pytest.mark.skip(
reason="""Playback fails for same event type triggered and test recording code
takes the event type has the dictionary it fails to recording call connected event for the connect api"""
)
@recorded_by_proxy_async
async def test_create_VOIP_call_connect_call_hangup_async(self):
# try to establish the call
Expand Down
6 changes: 0 additions & 6 deletions sdk/communication/azure-communication-callautomation/tests/test_e2e_media_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,6 @@ async def test_play_media_in_a_call(self):
await self.terminate_call(unique_id)
# Do not return anything from this test method

@pytest.mark.skip(
reason="Known issues - Bug 3949487: [GA4] [Python] [SDK] [Async] Get Participant fails with authentication error HMAC-SHA256, Bug 4182867: [SDK] Hmac Validation with ':' (GetParticipant) mismatch"
)
@recorded_by_proxy_async
async def test_add_and_mute_participant_in_a_call(self):
caller = await self.identity_client.create_user()
Expand Down Expand Up @@ -117,9 +114,6 @@ async def test_add_and_mute_participant_in_a_call(self):

await self.terminate_call(unique_id)

@pytest.mark.skip(
reason="Known issues - Bug 3949487: [GA4] [Python] [SDK] [Async] Get Participant fails with authentication error HMAC-SHA256, Bug 4182867: [SDK] Hmac Validation with ':' (GetParticipant) mismatch"
)
@recorded_by_proxy_async
async def test_add_and_hold_unhold_participant_in_a_call(self):
caller = await self.identity_client.create_user()
Expand Down
27 changes: 0 additions & 27 deletions sdk/communication/azure-communication-chat/azure/communication/chat/_shared/policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,33 +63,6 @@ def _sign_request(self, request: PipelineRequest) -> None:
if parsed_url.query:
query_url += "?" + parsed_url.query

# Need URL() to get a correct encoded key value, from "%3A" to ":", when transport is in type AioHttpTransport.
# There's a similar scenario in azure-storage-blob and azure-appconfiguration, the check logic is from there.
try:
from yarl import URL
from azure.core.pipeline.transport import ( # pylint:disable=non-abstract-transport-import
AioHttpTransport,
)

if (
isinstance(request.context.transport, AioHttpTransport)
or isinstance(
getattr(request.context.transport, "_transport", None),
AioHttpTransport,
)
or isinstance(
getattr(
getattr(request.context.transport, "_transport", None),
"_transport",
None,
),
AioHttpTransport,
)
):
query_url = str(URL(query_url))
except (ImportError, TypeError):
pass

if self._decode_url:
query_url = unquote(query_url)

Expand Down
27 changes: 0 additions & 27 deletions sdk/communication/azure-communication-email/azure/communication/email/_shared/policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,33 +63,6 @@ def _sign_request(self, request: PipelineRequest) -> None:
if parsed_url.query:
query_url += "?" + parsed_url.query

# Need URL() to get a correct encoded key value, from "%3A" to ":", when transport is in type AioHttpTransport.
# There's a similar scenario in azure-storage-blob and azure-appconfiguration, the check logic is from there.
try:
from yarl import URL
from azure.core.pipeline.transport import ( # pylint:disable=non-abstract-transport-import
AioHttpTransport,
)

if (
isinstance(request.context.transport, AioHttpTransport)
or isinstance(
getattr(request.context.transport, "_transport", None),
AioHttpTransport,
)
or isinstance(
getattr(
getattr(request.context.transport, "_transport", None),
"_transport",
None,
),
AioHttpTransport,
)
):
query_url = str(URL(query_url))
except (ImportError, TypeError):
pass

if self._decode_url:
query_url = unquote(query_url)

Expand Down
27 changes: 0 additions & 27 deletions ...communication/azure-communication-identity/azure/communication/identity/_shared/policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,33 +63,6 @@ def _sign_request(self, request: PipelineRequest) -> None:
if parsed_url.query:
query_url += "?" + parsed_url.query

# Need URL() to get a correct encoded key value, from "%3A" to ":", when transport is in type AioHttpTransport.
# There's a similar scenario in azure-storage-blob and azure-appconfiguration, the check logic is from there.
try:
from yarl import URL
from azure.core.pipeline.transport import ( # pylint:disable=non-abstract-transport-import
AioHttpTransport,
)

if (
isinstance(request.context.transport, AioHttpTransport)
or isinstance(
getattr(request.context.transport, "_transport", None),
AioHttpTransport,
)
or isinstance(
getattr(
getattr(request.context.transport, "_transport", None),
"_transport",
None,
),
AioHttpTransport,
)
):
query_url = str(URL(query_url))
except (ImportError, TypeError):
pass

if self._decode_url:
query_url = unquote(query_url)

Expand Down
27 changes: 0 additions & 27 deletions ...mmunication/azure-communication-jobrouter/azure/communication/jobrouter/_shared/policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,33 +63,6 @@ def _sign_request(self, request: PipelineRequest) -> None:
if parsed_url.query:
query_url += "?" + parsed_url.query

# Need URL() to get a correct encoded key value, from "%3A" to ":", when transport is in type AioHttpTransport.
# There's a similar scenario in azure-storage-blob and azure-appconfiguration, the check logic is from there.
try:
from yarl import URL
from azure.core.pipeline.transport import ( # pylint:disable=non-abstract-transport-import
AioHttpTransport,
)

if (
isinstance(request.context.transport, AioHttpTransport)
or isinstance(
getattr(request.context.transport, "_transport", None),
AioHttpTransport,
)
or isinstance(
getattr(
getattr(request.context.transport, "_transport", None),
"_transport",
None,
),
AioHttpTransport,
)
):
query_url = str(URL(query_url))
except (ImportError, TypeError):
pass

if self._decode_url:
query_url = unquote(query_url)

Expand Down
27 changes: 0 additions & 27 deletions ...communication/azure-communication-messages/azure/communication/messages/_shared/policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,33 +63,6 @@ def _sign_request(self, request: PipelineRequest) -> None:
if parsed_url.query:
query_url += "?" + parsed_url.query

# Need URL() to get a correct encoded key value, from "%3A" to ":", when transport is in type AioHttpTransport.
# There's a similar scenario in azure-storage-blob and azure-appconfiguration, the check logic is from there.
try:
from yarl import URL
from azure.core.pipeline.transport import ( # pylint:disable=non-abstract-transport-import
AioHttpTransport,
)

if (
isinstance(request.context.transport, AioHttpTransport)
or isinstance(
getattr(request.context.transport, "_transport", None),
AioHttpTransport,
)
or isinstance(
getattr(
getattr(request.context.transport, "_transport", None),
"_transport",
None,
),
AioHttpTransport,
)
):
query_url = str(URL(query_url))
except (ImportError, TypeError):
pass

if self._decode_url:
query_url = unquote(query_url)

Expand Down
27 changes: 0 additions & 27 deletions ...ation/azure-communication-phonenumbers/azure/communication/phonenumbers/_shared/policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,33 +63,6 @@ def _sign_request(self, request: PipelineRequest) -> None:
if parsed_url.query:
query_url += "?" + parsed_url.query

# Need URL() to get a correct encoded key value, from "%3A" to ":", when transport is in type AioHttpTransport.
# There's a similar scenario in azure-storage-blob and azure-appconfiguration, the check logic is from there.
try:
from yarl import URL
from azure.core.pipeline.transport import ( # pylint:disable=non-abstract-transport-import
AioHttpTransport,
)

if (
isinstance(request.context.transport, AioHttpTransport)
or isinstance(
getattr(request.context.transport, "_transport", None),
AioHttpTransport,
)
or isinstance(
getattr(
getattr(request.context.transport, "_transport", None),
"_transport",
None,
),
AioHttpTransport,
)
):
query_url = str(URL(query_url))
except (ImportError, TypeError):
pass

if self._decode_url:
query_url = unquote(query_url)

Expand Down
27 changes: 0 additions & 27 deletions sdk/communication/azure-communication-rooms/azure/communication/rooms/_shared/policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,33 +63,6 @@ def _sign_request(self, request: PipelineRequest) -> None:
if parsed_url.query:
query_url += "?" + parsed_url.query

# Need URL() to get a correct encoded key value, from "%3A" to ":", when transport is in type AioHttpTransport.
# There's a similar scenario in azure-storage-blob and azure-appconfiguration, the check logic is from there.
try:
from yarl import URL
from azure.core.pipeline.transport import ( # pylint:disable=non-abstract-transport-import
AioHttpTransport,
)

if (
isinstance(request.context.transport, AioHttpTransport)
or isinstance(
getattr(request.context.transport, "_transport", None),
AioHttpTransport,
)
or isinstance(
getattr(
getattr(request.context.transport, "_transport", None),
"_transport",
None,
),
AioHttpTransport,
)
):
query_url = str(URL(query_url))
except (ImportError, TypeError):
pass

if self._decode_url:
query_url = unquote(query_url)

Expand Down
27 changes: 0 additions & 27 deletions sdk/communication/azure-communication-sms/azure/communication/sms/_shared/policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,33 +63,6 @@ def _sign_request(self, request: PipelineRequest) -> None:
if parsed_url.query:
query_url += "?" + parsed_url.query

# Need URL() to get a correct encoded key value, from "%3A" to ":", when transport is in type AioHttpTransport.
# There's a similar scenario in azure-storage-blob and azure-appconfiguration, the check logic is from there.
try:
from yarl import URL
from azure.core.pipeline.transport import ( # pylint:disable=non-abstract-transport-import
AioHttpTransport,
)

if (
isinstance(request.context.transport, AioHttpTransport)
or isinstance(
getattr(request.context.transport, "_transport", None),
AioHttpTransport,
)
or isinstance(
getattr(
getattr(request.context.transport, "_transport", None),
"_transport",
None,
),
AioHttpTransport,
)
):
query_url = str(URL(query_url))
except (ImportError, TypeError):
pass

if self._decode_url:
query_url = unquote(query_url)

Expand Down