{CI} Ship .yaml test fixtures in azure_cli_fulltest wheel#33437
Open
naga-nandyala wants to merge 1 commit into
Open
{CI} Ship .yaml test fixtures in azure_cli_fulltest wheel#33437naga-nandyala wants to merge 1 commit into
naga-nandyala wants to merge 1 commit into
Conversation
Add *.yaml and **/*.yaml to package_data in scripts/ci/build.sh so non-recording fixtures (e.g. acr/tests/latest/taskfilesample.yaml) are included in the ephemeral azure_cli_fulltest wheel installed by TestRpmPackagesAzureLinux. Fixes test_acr_task FileNotFoundError after #33135 removed its @live_only decorator.
naga-nandyala
requested review from
YanaXu,
bebound,
jiasli,
wangzelin007 and
yonzhan
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @naga-nandyala, |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
Pan-Qi,
jsntcy and
kairu-ms
microsoft-github-policy-service
Bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CI-built azure-cli-fulltest wheel packaging rules so YAML-based test fixtures are included in the wheel, preventing fixture FileNotFoundErrors when tests run from the installed artifact.
Changes:
- Add
*.yamltopackage_dataso top-level YAML fixtures in test packages are included. - Add recursive
**/*.ymland**/*.yamlpatterns to include YAML fixtures in nested subdirectories of test packages.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add .yaml and **/.yaml to package_data in scripts/ci/build.sh so non-recording fixtures (e.g. acr/tests/latest/taskfilesample.yaml) are included in the ephemeral azure_cli_fulltest wheel installed by TestRpmPackagesAzureLinux. Fixes test_acr_task FileNotFoundError after #33135 removed its @live_only decorator.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.