{ACR} test tokens are masked#33436
Closed
msarfraz wants to merge 1 commit into
Closed
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @msarfraz, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
northtyphoon and
terencet-dev
Contributor
There was a problem hiding this comment.
Pull request overview
This PR sanitizes Azure Container Registry (ACR) test recordings to avoid committing sensitive OAuth token material (AAD access tokens and ACR refresh/access tokens) into the repo.
Changes:
- Masked
access_tokenvalues in recorded/oauth2/exchangerequest bodies. - Masked
refresh_tokenvalues returned from/oauth2/exchangeresponses. - Masked
refresh_tokenandaccess_tokenvalues in subsequent token-exchange request/response payloads.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_acr_login_expose_token.yaml |
Replaces recorded AAD access_token and ACR refresh_token with *** to prevent leaking token contents. |
src/azure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_acr_create_normal_check_health.yaml |
Replaces recorded AAD access_token, ACR refresh_token, and ACR access_token with *** across the exchange flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Obscured sensitive refresh token in test recording.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.