[App Service] Remove stale az webapp list-runtimes breaking change pre-announcements#33434
Conversation
…ments PR Azure#32903 ('az webapp list-runtimes: Revamp the command with structured table output') has been merged and ships the breaking changes that _breaking_change.py was pre-announcing: - The output is already a structured list of objects (os, runtime, version, config, support, end_of_life). - The --linux argument has been removed from _params.py. - The --show-runtime-details argument has been removed from _params.py. The register_output_breaking_change call still emits a 'will change' warning for an output format that has already changed, and the two register_argument_deprecate calls reference arguments that no longer exist. Delete the file so users don't see stale pre-announcement warnings now that the breaking change window is closing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
️✔️AzureCLI-FullTest
|
|
Hi @seligj95, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| webapp list-runtimes | cmd webapp list-runtimes removed property deprecate_info_target |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes the appservice “breaking change” registrations related to az webapp list-runtimes, effectively stopping the CLI from emitting the prior breaking-change/deprecation notices for that command.
Changes:
- Removes the registered output breaking-change notice for
webapp list-runtimes. - Removes deprecation/redirect registrations for
--linuxand--show-runtime-detailsonwebapp list-runtimes.
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/appservice/_breaking_change.py:1
- This change removes the only registrations that surface the
webapp list-runtimesoutput breaking-change notice and the deprecations/redirects for--linuxand--show-runtime-details. If those behaviors are still meant to be communicated/enforced for existing CLI versions, this will silently drop user-facing guidance (and potentially the redirect), changing CLI UX and backward-compat expectations. If the intent is to retire these notices because the breaking change window has passed, consider replacing this with an explicit removal (delete the module and any import side-effects) and add/refer to the tracking issue/release note that marks the deprecation as completed.
src/azure-cli/azure/cli/command_modules/appservice/_breaking_change.py:1 - After this diff, the module becomes empty (and also loses the standard file header). If the module is no longer needed, it’s cleaner to delete the file entirely (and remove any import that existed solely for side effects). If it must remain importable, keep the standard header and add a short module docstring explaining why it intentionally contains no breaking-change registrations to avoid confusing future maintainers and to satisfy repository file-header conventions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Related command
az webapp list-runtimesDescription
PR #32903 (
az webapp list-runtimes: Revamp the command with structured table output) has been merged and ships the breaking changes thatappservice/_breaking_change.pywas pre-announcing:os,runtime,version,config,support,end_of_life).--linuxargument has been removed from_params.py.--show-runtime-detailsargument has been removed from_params.py.As a result, the existing entries in
appservice/_breaking_change.pyare stale:register_output_breaking_changecall emits a "will change" warning for an output format that has already changed.register_argument_deprecatecalls reference arguments that no longer exist.This PR deletes
src/azure-cli/azure/cli/command_modules/appservice/_breaking_change.pyso users no longer see those pre-announcement warnings, now that the breaking change window is closing.Testing Guide
Verified locally that the appservice module loads with no entries left in
upcoming_breaking_changesforwebapp list-runtimesafter the deletion.History Notes
No HISTORY.rst entry needed — this only removes dead pre-announcement code; the actual breaking-change history entry will accompany #32903 in the next release.