Skip to content

fix(security): prevent GitHub Actions expression injection in build workflows (CWE-94) #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ganeshkumarashok wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(security): prevent GitHub Actions expression injection in build workflows (CWE-94) #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 73 additions & 24 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,16 @@ jobs:
fetch-depth: 0
- name: Load CUDA config
id: load_config
env:
CONFIG_KEY: ${{ matrix.config_key }}
run: |
cuda_version=$(yq e '.${{ matrix.config_key }}.version' driver_config.yml)
cuda_version=$(yq e ".${CONFIG_KEY}.version" driver_config.yml)
if [[ ! "$cuda_version" =~ ^[0-9]+(\.[0-9]+)+$ ]]; then
echo "::error::Refusing unexpected CUDA driver version: $cuda_version"
exit 1
fi
echo "CUDA_VERSION=$cuda_version"
echo "cuda_version=$cuda_version" >> $GITHUB_OUTPUT
echo "cuda_version=$cuda_version" >> "$GITHUB_OUTPUT"
- name: Set up QEMU
uses: docker/setup-qemu-action@v4
- name: Set up Docker Buildx
Expand All @@ -48,22 +54,31 @@ jobs:
${{ runner.os }}-buildx-${{ matrix.image_repo }}-
- name: Generate timestamp
id: timestamp
run: echo "timestamp=$(date +'%Y%m%d%H%M%S')" >> $GITHUB_OUTPUT
run: echo "timestamp=$(date +'%Y%m%d%H%M%S')" >> "$GITHUB_OUTPUT"
- uses: paulhatch/semantic-version@v6.0.2
with:
bump_each_commit: false
version_format: "${{ steps.load_config.outputs.cuda_version }}-${{ steps.timestamp.outputs.timestamp }}"
id: semver
- name: 'Check version'
env:
VERSION: ${{ steps.semver.outputs.version }}
VERSION_TAG: ${{ steps.semver.outputs.version_tag }}
run: |
echo "version is ${{ steps.semver.outputs.version }}"
echo "version is ${{ steps.semver.outputs.version_tag }}"
echo "version is $VERSION"
echo "version is $VERSION_TAG"
- name: 'Build and Push'
env:
DRIVER_VERSION: ${{ steps.load_config.outputs.cuda_version }}
IMAGE_REPO: ${{ matrix.image_repo }}
REGISTRY_SERVER: ${{ secrets.AZURE_REGISTRY_SERVER }}
VERSION: ${{ steps.semver.outputs.version }}
run: |
set -x
echo "tag is: "
echo ${{ steps.semver.outputs.version }}
docker buildx build --platform linux/arm64/v8,linux/amd64 --build-arg DRIVER_KIND=cuda --build-arg DRIVER_VERSION=${{ steps.load_config.outputs.cuda_version }} --cache-from=type=local,src=/tmp/.buildx-cache --cache-to=type=local,dest=/tmp/.buildx-cache-new --output=type=docker -t ${{ secrets.AZURE_REGISTRY_SERVER }}/public/aks/${{ matrix.image_repo }}:${{ steps.semver.outputs.version }} .
echo "$VERSION"
image_ref="${REGISTRY_SERVER}/public/aks/${IMAGE_REPO}:${VERSION}"
docker buildx build --platform linux/arm64/v8,linux/amd64 --build-arg DRIVER_KIND=cuda --build-arg "DRIVER_VERSION=${DRIVER_VERSION}" --cache-from=type=local,src=/tmp/.buildx-cache --cache-to=type=local,dest=/tmp/.buildx-cache-new --output=type=docker -t "$image_ref" .
docker images
- name: Move cache
run: |
Expand All @@ -84,10 +99,16 @@ jobs:
fetch-depth: 0
- name: Load CUDA config
id: load_config
env:
CONFIG_KEY: ${{ matrix.config_key }}
run: |
cuda_version=$(yq e '.${{ matrix.config_key }}.version' driver_config.yml)
cuda_version=$(yq e ".${CONFIG_KEY}.version" driver_config.yml)
if [[ ! "$cuda_version" =~ ^[0-9]+(\.[0-9]+)+$ ]]; then
echo "::error::Refusing unexpected CUDA driver version: $cuda_version"
exit 1
fi
echo "CUDA_VERSION=$cuda_version"
echo "cuda_version=$cuda_version" >> $GITHUB_OUTPUT
echo "cuda_version=$cuda_version" >> "$GITHUB_OUTPUT"
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v4
- name: Cache Docker layers
Expand All @@ -99,22 +120,31 @@ jobs:
${{ runner.os }}-buildx-${{ matrix.image_repo }}-
- name: Generate timestamp
id: timestamp
run: echo "timestamp=$(date +'%Y%m%d%H%M%S')" >> $GITHUB_OUTPUT
run: echo "timestamp=$(date +'%Y%m%d%H%M%S')" >> "$GITHUB_OUTPUT"
- uses: paulhatch/semantic-version@v6.0.2
with:
bump_each_commit: false
version_format: "${{ steps.load_config.outputs.cuda_version }}-${{ steps.timestamp.outputs.timestamp }}"
id: semver
- name: 'Check version'
env:
VERSION: ${{ steps.semver.outputs.version }}
VERSION_TAG: ${{ steps.semver.outputs.version_tag }}
run: |
echo "version is ${{ steps.semver.outputs.version }}"
echo "version is ${{ steps.semver.outputs.version_tag }}"
echo "version is $VERSION"
echo "version is $VERSION_TAG"
- name: 'Build and Push'
env:
DRIVER_VERSION: ${{ steps.load_config.outputs.cuda_version }}
IMAGE_REPO: ${{ matrix.image_repo }}
REGISTRY_SERVER: ${{ secrets.AZURE_REGISTRY_SERVER }}
VERSION: ${{ steps.semver.outputs.version }}
run: |
set -x
echo "tag is: "
echo ${{ steps.semver.outputs.version }}
docker buildx build --build-arg DRIVER_KIND=cuda --build-arg DRIVER_VERSION=${{ steps.load_config.outputs.cuda_version }} --cache-from=type=local,src=/tmp/.buildx-cache --cache-to=type=local,dest=/tmp/.buildx-cache-new --output=type=docker -t ${{ secrets.AZURE_REGISTRY_SERVER }}/public/aks/${{ matrix.image_repo }}:${{ steps.semver.outputs.version }} .
echo "$VERSION"
image_ref="${REGISTRY_SERVER}/public/aks/${IMAGE_REPO}:${VERSION}"
docker buildx build --build-arg DRIVER_KIND=cuda --build-arg "DRIVER_VERSION=${DRIVER_VERSION}" --cache-from=type=local,src=/tmp/.buildx-cache --cache-to=type=local,dest=/tmp/.buildx-cache-new --output=type=docker -t "$image_ref" .
docker images
- name: Move cache
run: |
Expand All @@ -135,13 +165,23 @@ jobs:
fetch-depth: 0
- name: Load GRID config
id: load_config
env:
CONFIG_KEY: ${{ matrix.config_key }}
run: |
grid_version=$(yq e '.${{ matrix.config_key }}.version' driver_config.yml)
grid_url=$(yq e '.${{ matrix.config_key }}.url' driver_config.yml)
grid_version=$(yq e ".${CONFIG_KEY}.version" driver_config.yml)
grid_url=$(yq e ".${CONFIG_KEY}.url" driver_config.yml)
if [[ ! "$grid_version" =~ ^[0-9]+(\.[0-9]+)+$ ]]; then
echo "::error::Refusing unexpected GRID driver version: $grid_version"
exit 1
fi
if [[ ! "$grid_url" =~ ^https://[A-Za-z0-9._~:/?#@%+=-]+$ ]]; then
echo "::error::Refusing unexpected GRID driver URL: $grid_url"
exit 1
fi
echo "GRID_VERSION=$grid_version"
echo "GRID_URL=$grid_url"
echo "grid_version=$grid_version" >> $GITHUB_OUTPUT
echo "grid_url=$grid_url" >> $GITHUB_OUTPUT
echo "grid_version=$grid_version" >> "$GITHUB_OUTPUT"
echo "grid_url=$grid_url" >> "$GITHUB_OUTPUT"
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v4
- name: Cache Docker layers
Expand All @@ -153,25 +193,34 @@ jobs:
${{ runner.os }}-buildx-${{ matrix.image_repo }}-${{ steps.load_config.outputs.grid_version }}
- name: Generate timestamp
id: timestamp
run: echo "timestamp=$(date +'%Y%m%d%H%M%S')" >> $GITHUB_OUTPUT
run: echo "timestamp=$(date +'%Y%m%d%H%M%S')" >> "$GITHUB_OUTPUT"
- uses: paulhatch/semantic-version@v6.0.2
with:
bump_each_commit: false
version_format: "${{ steps.load_config.outputs.grid_version }}-${{ steps.timestamp.outputs.timestamp }}"
id: semver
- name: 'Check version'
env:
VERSION: ${{ steps.semver.outputs.version }}
VERSION_TAG: ${{ steps.semver.outputs.version_tag }}
run: |
echo "version is ${{ steps.semver.outputs.version }}"
echo "version is ${{ steps.semver.outputs.version_tag }}"
echo "version is $VERSION"
echo "version is $VERSION_TAG"
- name: 'Build and Push'
env:
DRIVER_URL: ${{ steps.load_config.outputs.grid_url }}
DRIVER_VERSION: ${{ steps.load_config.outputs.grid_version }}
IMAGE_REPO: ${{ matrix.image_repo }}
REGISTRY_SERVER: ${{ secrets.AZURE_REGISTRY_SERVER }}
VERSION: ${{ steps.semver.outputs.version }}
run: |
set -x
echo "tag is: "
echo ${{ steps.semver.outputs.version }}
docker buildx build --build-arg DRIVER_URL=${{ steps.load_config.outputs.grid_url }} --build-arg DRIVER_KIND=grid --build-arg DRIVER_VERSION=${{ steps.load_config.outputs.grid_version }} --cache-from=type=local,src=/tmp/.buildx-cache --cache-to=type=local,dest=/tmp/.buildx-cache-new --output=type=docker -t ${{ secrets.AZURE_REGISTRY_SERVER }}/public/aks/${{ matrix.image_repo }}:${{ steps.semver.outputs.version }} .
echo "$VERSION"
image_ref="${REGISTRY_SERVER}/public/aks/${IMAGE_REPO}:${VERSION}"
docker buildx build --build-arg "DRIVER_URL=${DRIVER_URL}" --build-arg DRIVER_KIND=grid --build-arg "DRIVER_VERSION=${DRIVER_VERSION}" --cache-from=type=local,src=/tmp/.buildx-cache --cache-to=type=local,dest=/tmp/.buildx-cache-new --output=type=docker -t "$image_ref" .
docker images
- name: Move cache
run: |
rm -rf /tmp/.buildx-cache
mv /tmp/.buildx-cache-new /tmp/.buildx-cache

Loading
Loading