GoToTicket box is shown on all pages#131
Conversation
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
- Coverage 61.66% 61.56% -0.11%
==========================================
Files 95 95
Lines 1414 1418 +4
==========================================
+ Hits 872 873 +1
- Misses 542 545 +3
Continue to review full report at Codecov.
|
|
For some reason this doesn't run on my machine:
|
alrodrig1
left a comment
alrodrig1
left a comment
There was a problem hiding this comment.
Managed to build and run on my local. This seems to be the correct functionality.
Regarding layout, something like this probably works:
Also, make sure to remove the search page, and remove it from the menu as well.
danieljurek
left a comment
danieljurek
left a comment
There was a problem hiding this comment.
Only one comment worth consideration: incidentActions.js:147
The others don't require the action specified or require action in general.
| } | ||
|
|
||
| export const updateIncidentCreationInput = (input) => ({ | ||
| export const updateTicketNavigationInput = (input, history) => ({ |
There was a problem hiding this comment.
history appears to go unused in any calls to updateTicketNavigationInput and within the function body itself. Is it necessary?
| }) | ||
| }) | ||
|
|
||
| describe('GoToTicket render output', function () { |
There was a problem hiding this comment.
No need to change anything here... Taking advantage of another soapbox opportunity
These tests are manually verifying aspects of the component but they're not handling scenarios where, for example, a child could be added after result.props.children[1]
| export const ConnectedGoToTicketForm = connect(mapStateToProps)(GoToTicketForm) | ||
|
|
||
| export const GoToTicket = ({history}) => <Paper zDepth={1}> | ||
| <span>Go To Ticket:</span> |
There was a problem hiding this comment.
[This will almost certainly be less relevant given our discussion at the standup]
The <form> tag results in a line break... which makes the form harder to understand and creates an opportunity to evangelize styles.
To get "Go To Ticket" on the same line as the form:
// After the includes, near the top of the file:
const styles = {
inlineForm: { display: 'inline', padding: '16px' }
}
...
export const GoToTicketForm = ({input, creationError, history, dispatch}) => <form
id='incident-navigation'
onSubmit={onSubmit(input, history)}
style={styles.inlineForm} // <-- Access the styles object to apply the styles to the element
>
...
There was a problem hiding this comment.
From our conversation earlier and the wireframe up top, Toolbars might give us what we need here: http://www.material-ui.com/#/components/toolbar
5 participants
For Task 47549: Replace "Incident Search" page with "Go to Ticket" field.
This is extremely unlikely to be the style/layout we want, but is this the correct functionality? GoToTicket is shown on all pages.