Skip to content

revert(designer): Add back HL7#9239

Merged
lambrianmsft merged 12 commits into
mainfrom
eric/hl7
Jun 4, 2026
Merged

revert(designer): Add back HL7#9239
lambrianmsft merged 12 commits into
mainfrom
eric/hl7

Conversation

@Eric-B-Wu
Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

revert change of #9238

Impact of Change

  • Users: Add back HL7 manifests
  • Developers: no dev changes
  • System: no system changes

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@Eric-B-Wu

Screenshots/Videos

Copilot AI review requested due to automatic review settings June 4, 2026 02:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: revert(designer): Add back HL7
  • Issue: None — this is a clear revert-style title and appropriately identifies the scope.
  • Recommendation: No change needed.

Commit Type

  • Properly selected (fix).
  • Only one commit type is selected, which is correct.

⚠️ Risk Level

  • The submitted risk level is Low, and that is reasonable for a narrow revert that restores HL7 manifests.
  • Advised risk remains Low based on the diff.

What & Why

  • Current: revert change of https://github.com/Azure/LogicAppsUX/pull/9238
  • Issue: Acceptable, but slightly terse. It would be clearer to state that this restores HL7 operation manifests after the prior change.
  • Recommendation: Consider: Revert the HL7 removal so the HL7 decode/encode manifests are available again.

Impact of Change

  • The impact section is present and consistent with the diff.
  • Recommendation:
    • Users: Add back HL7 manifests
    • Developers: no dev changes
    • System: no system changes

Test Plan

  • Manual testing is checked, and this is sufficient here because the PR is a narrow revert with straightforward manifest registration changes. No additional automated test requirement is indicated by the diff.

Contributors

  • Contributor credit is present.
  • No action required.

Screenshots/Videos

  • No visual changes are implied by the diff, so this can remain blank.

Summary Table

Section Status Recommendation
Title No change needed
Commit Type Keep fix selected
Risk Level Low is appropriate
What & Why Optionally clarify the HL7 restore intent
Impact of Change Looks good
Test Plan Manual testing is sufficient here
Contributors Looks good
Screenshots/Videos Not required

Overall: this PR passes. The advised risk level is not higher than the submitter’s estimate.


Last updated: Thu, 04 Jun 2026 02:31:28 GMT

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts a prior change by reintroducing HL7 operation types into the shared operation manifest plumbing, so HL7 encode/decode operations are again recognized as built-in and can resolve operation info/manifest metadata correctly.

Changes:

  • Re-added hl7decode / hl7encode operation type constants and included them in supportedBaseManifestTypes.
  • Treated HL7 encode/decode as built-in operations via isBuiltInOperation.
  • Added HL7 entries to built-in operation metadata using the connectionProviders/hl7Operations connector group.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

📊 Coverage Check

No source files changed in this PR.

@lambrianmsft lambrianmsft enabled auto-merge (squash) June 4, 2026 03:15
@lambrianmsft lambrianmsft merged commit 12f31a8 into main Jun 4, 2026
50 of 58 checks passed
@lambrianmsft lambrianmsft deleted the eric/hl7 branch June 4, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants