updates to loop logic and readme#14505
Open
AcceleryntSecurityDev wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR consolidates the Checkmarx Audit Ingestion deployment into a single ARM template while updating the Logic App pagination loop and improving documentation to match the new deployment model.
Changes:
- Collapsed multi-step deployments (table/DCE/DCR) into a single
azuredeploy.jsonthat also provisions role assignments. - Reworked Logic App pagination to follow
next.hreflinks and introduced configurable lookback days. - Updated README to reflect one-click deployment, RBAC notes, and updated query/dedup guidance.
Reviewed changes
Copilot reviewed 5 out of 24 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Playbooks/AS-Checkmarx-Audit-Ingestion/azuredeploy.json | Consolidates resources into one deployment, updates loop/pagination logic, adds workspace/DCE/DCR parameters, and creates role assignments. |
| Playbooks/AS-Checkmarx-Audit-Ingestion/README.md | Updates deployment and operational guidance to match the single-template deployment and new pagination behavior. |
| Playbooks/AS-Checkmarx-Audit-Ingestion/AzureDeployDCE.json | Removed legacy standalone DCE deployment template (superseded by consolidated template). |
| Playbooks/AS-Checkmarx-Audit-Ingestion/AzureDeployAuditTable.json | Removed legacy standalone table deployment template (superseded by consolidated template). |
| Playbooks/AS-Checkmarx-Audit-Ingestion/AzureDeployAuditDCR.json | Removed legacy standalone DCR deployment template (superseded by consolidated template). |
Comments suppressed due to low confidence (1)
Playbooks/AS-Checkmarx-Audit-Ingestion/azuredeploy.json:1
- The DCR transform adds
TimeGenerated, butTimeGeneratedis not included in the stream declaration schema. DCR transforms generally must output columns that exist in the declared output stream schema; otherwise, deployment or ingestion can fail due to schema mismatch. AddTimeGeneratedto the stream declaration (and ensure the output stream schema includes it) so the transform output aligns with the declared stream.
{
| { | ||
| "name": "FromDate", | ||
| "type": "string", | ||
| "value": "[concat('@{addDays(utcNow(), -', parameters('LookbackDays'), ', ''yyyy-MM-ddTHH:mm:ssZ'')}')]" |
| }, | ||
| "Initialize_variable_-_AuditHasMore": { | ||
| "type": "InitializeVariable", | ||
| "Set_Variable_-_NextPageUrl_Initial": { |
| } | ||
| ] | ||
| "name": "NextPageUrl", | ||
| "value": "[concat('@{concat(''', parameters('CheckmarxASTBaseUrl'), '/api/audit-events/?startDate='', variables(''FromDate''), ''&offset=0&limit='', variables(''AuditPageSize''))}')]" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change(s):
Version Updated:
-N/A
Testing Completed: