Skip to content

updates to loop logic and readme#14505

Open
AcceleryntSecurityDev wants to merge 1 commit into
Azure:masterfrom
Accelerynt-Security:06-16-2026--AS-Checkmarx-Audit-Ingestion
Open

updates to loop logic and readme#14505
AcceleryntSecurityDev wants to merge 1 commit into
Azure:masterfrom
Accelerynt-Security:06-16-2026--AS-Checkmarx-Audit-Ingestion

Conversation

@AcceleryntSecurityDev

Copy link
Copy Markdown
Contributor

Reason for Change(s):

  • Updates to pagination logic, loop optimization, improvements to documentation

Version Updated:
-N/A

Testing Completed:

  • Yes
image

@AcceleryntSecurityDev AcceleryntSecurityDev requested review from a team as code owners June 17, 2026 03:07
@v-maheshbh v-maheshbh self-assigned this Jun 17, 2026
@v-maheshbh v-maheshbh added the Playbook Playbook specialty review needed label Jun 17, 2026
@v-maheshbh v-maheshbh requested a review from Copilot June 17, 2026 04:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR consolidates the Checkmarx Audit Ingestion deployment into a single ARM template while updating the Logic App pagination loop and improving documentation to match the new deployment model.

Changes:

  • Collapsed multi-step deployments (table/DCE/DCR) into a single azuredeploy.json that also provisions role assignments.
  • Reworked Logic App pagination to follow next.href links and introduced configurable lookback days.
  • Updated README to reflect one-click deployment, RBAC notes, and updated query/dedup guidance.

Reviewed changes

Copilot reviewed 5 out of 24 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Playbooks/AS-Checkmarx-Audit-Ingestion/azuredeploy.json Consolidates resources into one deployment, updates loop/pagination logic, adds workspace/DCE/DCR parameters, and creates role assignments.
Playbooks/AS-Checkmarx-Audit-Ingestion/README.md Updates deployment and operational guidance to match the single-template deployment and new pagination behavior.
Playbooks/AS-Checkmarx-Audit-Ingestion/AzureDeployDCE.json Removed legacy standalone DCE deployment template (superseded by consolidated template).
Playbooks/AS-Checkmarx-Audit-Ingestion/AzureDeployAuditTable.json Removed legacy standalone table deployment template (superseded by consolidated template).
Playbooks/AS-Checkmarx-Audit-Ingestion/AzureDeployAuditDCR.json Removed legacy standalone DCR deployment template (superseded by consolidated template).
Comments suppressed due to low confidence (1)

Playbooks/AS-Checkmarx-Audit-Ingestion/azuredeploy.json:1

  • The DCR transform adds TimeGenerated, but TimeGenerated is not included in the stream declaration schema. DCR transforms generally must output columns that exist in the declared output stream schema; otherwise, deployment or ingestion can fail due to schema mismatch. Add TimeGenerated to the stream declaration (and ensure the output stream schema includes it) so the transform output aligns with the declared stream.
{

{
"name": "FromDate",
"type": "string",
"value": "[concat('@{addDays(utcNow(), -', parameters('LookbackDays'), ', ''yyyy-MM-ddTHH:mm:ssZ'')}')]"
},
"Initialize_variable_-_AuditHasMore": {
"type": "InitializeVariable",
"Set_Variable_-_NextPageUrl_Initial": {
}
]
"name": "NextPageUrl",
"value": "[concat('@{concat(''', parameters('CheckmarxASTBaseUrl'), '/api/audit-events/?startDate='', variables(''FromDate''), ''&offset=0&limit='', variables(''AuditPageSize''))}')]"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Playbook Playbook specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants