Fix Snowflake paging config - use GET for subsequent requests#14502
Open
v-krishnachi wants to merge 1 commit into
Open
Fix Snowflake paging config - use GET for subsequent requests#14502v-krishnachi wants to merge 1 commit into
v-krishnachi wants to merge 1 commit into
Conversation
Updated paging configuration across all 10 pollers to fix paging gap: - Added linkHeaderTokenJsonPath with simplified $.statementStatusUrl - Added nextPageHttpMethod: GET (initial POST, subsequent GET) - Added isNextPageTokenRelativeUrl: true - Removed old concat-style URL from linkHeaderTokenJsonPath Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes Snowflake connector pagination by switching subsequent page fetches to GET and simplifying the next-page token extraction to avoid paging gaps.
Changes:
- Updated paging token extraction to use
$.statementStatusUrldirectly. - Added
nextPageHttpMethod: GETfor follow-up requests and marked tokens as relative URLs. - Applied the paging config updates across all pollers/config entries (source config + packaged template).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Solutions/Snowflake/Package/mainTemplate.json | Updates the packaged Snowflake polling definitions to use the corrected paging behavior. |
| Solutions/Snowflake/Data Connectors/SnowflakeLogs_ccp/SnowflakeLogs_PollingConfig.json | Updates the source polling config to use JSONPath token extraction and GET for subsequent pages. |
Comment on lines
2468
to
2473
| "paging": { | ||
| "pagingType": "LinkHeader", | ||
| "linkHeaderTokenJsonPath": "[[concat('https://',parameters('accountId'),'.snowflakecomputing.com','$.statementStatusUrl')]" | ||
| "linkHeaderTokenJsonPath": "$.statementStatusUrl", | ||
| "nextPageHttpMethod": "GET", | ||
| "isNextPageTokenRelativeUrl": true | ||
| }, |
Comment on lines
+42
to
+44
| "linkHeaderTokenJsonPath": "$.statementStatusUrl", | ||
| "nextPageHttpMethod": "GET", | ||
| "isNextPageTokenRelativeUrl": true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated paging configuration across all 10 pollers to fix paging gap:
Added linkHeaderTokenJsonPath with simplified $.statementStatusUrl
Added nextPageHttpMethod: GET (initial POST, subsequent GET)
Added isNextPageTokenRelativeUrl: true
Removed old concat-style URL from linkHeaderTokenJsonPath
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: