fix(config): register Microsoft.ContainerInstance on mgmt subscriptions (ARO-28100)#5893
Conversation
…ns (ARO-28100) The swift-vnet step creates an ACI (az container create) in the management subscription, but Microsoft.ContainerInstance was not in mgmt.subscription.providers, so a fresh management subscription with Swift enabled could fail az container create with MissingSubscriptionRegistration. Add Microsoft.ContainerInstance to the mgmt providers list so the rpRegistration step registers it before swift-vnet runs, making fresh-subscription rollouts deterministic. Rendered dev configs regenerated via 'make -C config/ materialize'. Existing int/stg/prod mgmt subscriptions already have the provider registered (Azure#5834's e2e ran the container), so this is a fast-follow hardening, not a fix for the current reland (Azure#5889). Flagged by Copilot review on Azure#5889.
There was a problem hiding this comment.
Pull request overview
Registers the Microsoft.ContainerInstance resource provider for management subscriptions by adding it to the shared mgmt.subscription.providers defaults and regenerating the rendered dev config outputs, ensuring swift-vnet (which uses Azure Container Instances in the mgmt subscription) won’t fail on freshly created subscriptions due to missing RP registration.
Changes:
- Add
Microsoft.ContainerInstance(withpoll: true) todefaults.mgmt.subscription.providersinconfig/config.yaml. - Regenerate rendered dev configs so the new provider appears in the materialized per-environment YAML outputs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| config/config.yaml | Adds Microsoft.ContainerInstance to the mgmt subscription provider registration defaults. |
| config/rendered/dev/pers/westus3.yaml | Materialized dev config updated to include Microsoft.ContainerInstance under mgmt providers. |
| config/rendered/dev/perf/westus3.yaml | Materialized dev config updated to include Microsoft.ContainerInstance under mgmt providers. |
| config/rendered/dev/dev/westus3.yaml | Materialized dev config updated to include Microsoft.ContainerInstance under mgmt providers. |
| config/rendered/dev/cspr/westus3.yaml | Materialized dev config updated to include Microsoft.ContainerInstance under mgmt providers. |
| config/rendered/dev/ci01/centralus.yaml | Materialized dev config updated to include Microsoft.ContainerInstance under mgmt providers. |
| config/rendered/dev/ci00/centralus.yaml | Materialized dev config updated to include Microsoft.ContainerInstance under mgmt providers. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmazur, raelga The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ARO-28100 (epic ARO-28038)
What
Add
Microsoft.ContainerInstanceto the management subscription providers list (mgmt.subscription.providersinconfig/config.yaml) and regenerate the rendered dev configs (make -C config/ materialize).Why
The
swift-vnetstep (#5834, relanded in #5889) creates an Azure Container Instance (az container create) in the management subscription to run the Swift VNet create/tag as the Swift-registered globalMSI. That subscription's registered providers did not includeMicrosoft.ContainerInstance, andswift-vnetis the first ACI user in the repo. On a brand-new management subscription with Swift enabled,az container createcould fail withMissingSubscriptionRegistration.Adding it to the providers list means the existing
rpRegistrationstep registers it beforeswift-vnetruns, making fresh region buildouts deterministic. Existing int/stg/prod mgmt subscriptions already have it registered (#5834's e2e ran the container), so this is a fast-follow hardening — not a fix for the current reland.Flagged by Copilot review on #5889.
Testing
make -C config/ materialize— rendered dev configs regenerated; onlyMicrosoft.ContainerInstanceadded.verify-materialize(make -C config/ detect-change) is clean after committing the rendered outputs.Special notes for your reviewer
mgmt-solo-pipeline.yamlis intentionally not touched: it is a manual/dev-only pipeline (not in any topology) with norpRegistrationstep, and assumes a pre-registered subscription.PR Checklist