chore: refresh upstream distrobox-enter baseline#29
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| result_command="${result_command} | ||
| $(printenv | grep '=' | grep -Ev '"|`|\$' | | ||
| grep -Ev '^(CONTAINER_ID|FPATH|HOST|HOSTNAME|HOME|PATH|PROFILEREAD|SHELL|XDG_SEAT|XDG_VTNR|XDG_.*_DIRS|^_)' | | ||
| sed 's/ /\ /g' | sed 's/^\(.*\)$/--env=\1/g')" |
There was a problem hiding this comment.
The new env-export block escapes spaces with sed 's/ /\\ /g' and then injects the resulting text directly into result_command, but the later assembly loop splits only on newlines, so the backslashes are preserved as part of the argument. If a host variable contains spaces (e.g., MYVAR='foo bar'), the container will now receive MYVAR=foo\ bar instead of MYVAR=foo bar, corrupting the value; previously such vars were simply skipped rather than mis-set.
Useful? React with 👍 / 👎.
8d6251c to
e9c78d5
Compare
e9c78d5 to
6d4f86c
Compare
6d4f86c to
aeeea4f
Compare
1 participant
Automated refresh of
scripts/upstream/distrobox-enter.upstreamfrom upstream.Reminder:
scripts/devbox-enteris a fork that applies env vars viaenvaftersuto preserve XAUTHORITY/GUI vars. Keep that behavior when rebasing onto upstream changes.