Add aarch64 support (#305)#306
Merged
Merged
Conversation
Upstream GitKraken ships Linux ARM64 binaries, so package both arches. - PKGBUILD: arch=(x86_64 aarch64) with per-arch source_*/sha256sums_* arrays; package() is unchanged since both tarballs extract to gitkraken/ - update.sh: hash the aarch64 tarball directly, since updpkgsums only refreshes the build host's architecture on an x86_64 runner - CI: add a matrix job verifying each arch's source URL, checksum, and tarball layout (gitkraken/gitkraken + gitkraken.png) - .SRCINFO regenerated; README notes the cross-arch checksum caveat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #305.
Upstream GitKraken ships Linux ARM64 binaries, so this packages both architectures.
Changes
arch=(x86_64 aarch64)with per-archsource_*/sha256sums_*arrays.package()is unchanged — both tarballs extract togitkraken/, so install logic is identical. ARM64 URL:.../linux/arm64/${pkgver}/gitkraken-aarch64.tar.gz(path isarm64, filename isaarch64).updpkgsumsonly refreshes the build host architecture on the x86_64 update runner.gitkraken/gitkraken+gitkraken.png).makepkg --printsrcinfo; README notes the cross-arch checksum caveat.Verification (in an Arch container)
makepkgbuild of the x86_64 package —package()produces/opt/gitkraken/gitkraken, the launcher, desktop file, and icon.SRCINFOregenerated from the new PKGBUILD;shellcheck update.shcleanNote
The existing
arch-pkgbuild-buildervalidation action uses an amd64-only image, so a real aarch64makepkgbuild cannot run in CI (and we only repackage a prebuilt binary — no compilation). The source-verification matrix job covers the actual risk: wrong URL, bad checksum, or changed tarball layout.