Fix/homogenize file check ui#77
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR homogenizes the FileCheck UI with FilePreview and fixes spinner rendering by adjusting layout, typography, and SVG sizing so the finish screen looks visually consistent and scales correctly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- By removing the responsive
@xlsizing fromCardandWrapperand hardcoding 150×200, the layout may no longer adapt well to different breakpoints; consider whether you need separate sizes or CSS-based scaling for smaller viewports. - Switching from
styled.h3tostyled.h2for the finish subtitle changes the semantic heading hierarchy; double-check that this still matches the overall page structure and accessibility expectations. - Now that the spinner SVG has a
viewBox, you may not need to set both width/height in the component and via styled CSS; consider standardizing on one sizing approach to avoid conflicts or confusion.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- By removing the responsive `@xl` sizing from `Card` and `Wrapper` and hardcoding 150×200, the layout may no longer adapt well to different breakpoints; consider whether you need separate sizes or CSS-based scaling for smaller viewports.
- Switching from `styled.h3` to `styled.h2` for the finish subtitle changes the semantic heading hierarchy; double-check that this still matches the overall page structure and accessibility expectations.
- Now that the spinner SVG has a `viewBox`, you may not need to set both width/height in the component and via styled CSS; consider standardizing on one sizing approach to avoid conflicts or confusion.
## Individual Comments
### Comment 1
<location path="src/renderer/src/components/finish/finish-main-content.tsx" line_range="29" />
<code_context>
<Card>
<Stack gap={{ base: "4", xl: "8" }}>
- <styled.h3>{t("finish.subtitle")}</styled.h3>
+ <styled.h2 textStyle="subtitle.md.default">{t("finish.subtitle")}</styled.h2>
<Grid columns={4} gap="8" justifyContent="center" width="full">
{children}
</code_context>
<issue_to_address>
**issue (bug_risk):** Changing this from h3 to h2 could affect heading hierarchy and accessibility.
If there’s already an `h1`/`h2` earlier on the page, this promotion could disrupt the logical heading order used by screen readers and in-page navigation. Please review the page’s overall outline; if this is mainly a visual change, consider keeping it as an `h3` and applying `textStyle="subtitle.md.default"` via styling instead.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| <Card> | ||
| <Stack gap={{ base: "4", xl: "8" }}> | ||
| <styled.h3>{t("finish.subtitle")}</styled.h3> | ||
| <styled.h2 textStyle="subtitle.md.default">{t("finish.subtitle")}</styled.h2> |
There was a problem hiding this comment.
issue (bug_risk): Changing this from h3 to h2 could affect heading hierarchy and accessibility.
If there’s already an h1/h2 earlier on the page, this promotion could disrupt the logical heading order used by screen readers and in-page navigation. Please review the page’s overall outline; if this is mainly a visual change, consider keeping it as an h3 and applying textStyle="subtitle.md.default" via styling instead.
There was a problem hiding this comment.
Pull request overview
This PR fixes a UI rendering issue with the loading spinner and homogenizes the FileCheck tile styling to match FilePreview, improving visual consistency across preview/finish screens.
Changes:
- Added an SVG
viewBoxtoSpinnerso it scales correctly when resized via CSS (avoids clipping/distortion). - Standardized
FileChecktile/card dimensions and filename typography to align withFilePreview. - Updated the finish screen subtitle to use the shared
subtitle.md.defaulttext style.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/renderer/src/components/spinner/index.tsx | Adds viewBox to ensure the spinner scales without clipping. |
| src/renderer/src/components/finish/finish-main-content.tsx | Applies shared subtitle text style for finish screen consistency. |
| src/renderer/src/components/file-check/index.tsx | Sets filename Text size to match FilePreview typography. |
| src/renderer/src/components/file-check/FileCheck.styles.ts | Aligns FileCheck wrapper/card sizing with FilePreview tile dimensions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <Icon {...{ hasError, isLoading }} /> | ||
| </Card> | ||
| <Text>{fileName}</Text> | ||
| <Text size="s">{fileName}</Text> |
Se corrigió el renderizado del spinner en la pantalla de finalización del anonimizador y se unificó el estilo del componente
FileCheckpara que sea visualmente consistente conFilePreview.Cambios:
viewBoxal SVG delSpinnerpara que escale correctamente al ser redimensionado por CSS (evitaba el recorte que lo hacía verse "chueco")FileCheck(150×200) con las deFilePreviewtextStyleal subtítulo de la pantalla de finalización que en la pantalla de previewsize="s") enFileCheckSummary by Sourcery
Align file check UI and loading spinner behavior with the file preview and finish screens for consistent layout and typography.
Bug Fixes:
Enhancements: