Fix dependabot security alerts for minimatch and serialize-javascript#194
Conversation
Bump minimatch 3.1.2 -> 3.1.3 and 5.1.6 -> 5.1.8 in yarn.lock to resolve Dependabot alerts Axosoft#36 and Axosoft#37 (combinatorial backtracking via multiple non-adjacent GLOBSTAR segments). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add yarn resolution to force serialize-javascript ^7.0.3, which fixes CVE for RCE via RegExp.flags and Date.prototype.toISOString(). Mocha depends on serialize-javascript ^6.0.2 but no 6.x patch exists. The only breaking change in v7 is requiring Node.js v20+, which is fine since this is a dev-only dependency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
serialize-javascript v7 requires Node.js 20+, so remove Node 18 from the test matrix. Add CHANGELOG.md documenting the security fixes and the new minimum Node.js version for development. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@ianhattendorf @julianmesa-gitkraken can someone please help us with understanding what do to with the merge requirements (tests that aren't running)? And also we'd like to release a version bump, not sure if there's any special steps there. |
There were branch protection rules (https://github.com/Axosoft/nsfw/settings/branches) requiring that the Node 18 tests pass. Since support for Node 18 is being dropped, I've removed those checks. For releasing: it's a yarn project so you'll want to |
Summary
minimatch3.1.2 → 3.1.3 and 5.1.6 → 5.1.8 in yarn.lock to fix ReDoS vulnerability (Dependabot alerts add cpp interface and unit tests #36, Does this module support remote shares? #37)serialize-javascript^7.0.3 to fix RCE via RegExp.flags and Date.prototype.toISOString() (Dependabot alert Error installing on windows 10 #38). No 6.x patch exists; the only breaking change in v7 is requiring Node.js v20+, which only affects dev tooling.Test plan
yarn installsucceeds🤖 Generated with Claude Code