Skip to content

Fix dependabot security alerts for minimatch and serialize-javascript#194

Merged
Mr-Wallet merged 3 commits into
Axosoft:masterfrom
Mr-Wallet:fix/dependabot-alerts
Mar 16, 2026
Merged

Fix dependabot security alerts for minimatch and serialize-javascript#194
Mr-Wallet merged 3 commits into
Axosoft:masterfrom
Mr-Wallet:fix/dependabot-alerts

Conversation

@Mr-Wallet
Copy link
Copy Markdown
Contributor

Summary

Test plan

  • yarn install succeeds
  • Native build compiles successfully
  • CI passes

🤖 Generated with Claude Code

Mr-Wallet and others added 3 commits March 6, 2026 08:06
Bump minimatch 3.1.2 -> 3.1.3 and 5.1.6 -> 5.1.8 in yarn.lock
to resolve Dependabot alerts Axosoft#36 and Axosoft#37 (combinatorial backtracking
via multiple non-adjacent GLOBSTAR segments).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add yarn resolution to force serialize-javascript ^7.0.3, which fixes
CVE for RCE via RegExp.flags and Date.prototype.toISOString().

Mocha depends on serialize-javascript ^6.0.2 but no 6.x patch exists.
The only breaking change in v7 is requiring Node.js v20+, which is
fine since this is a dev-only dependency.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
serialize-javascript v7 requires Node.js 20+, so remove Node 18 from
the test matrix. Add CHANGELOG.md documenting the security fixes and
the new minimum Node.js version for development.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Mr-Wallet Mr-Wallet requested a review from AlexaXs March 10, 2026 22:09
Copy link
Copy Markdown

@AlexaXs AlexaXs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working fine

@Mr-Wallet
Copy link
Copy Markdown
Contributor Author

@ianhattendorf @julianmesa-gitkraken can someone please help us with understanding what do to with the merge requirements (tests that aren't running)? And also we'd like to release a version bump, not sure if there's any special steps there.

@ianhattendorf
Copy link
Copy Markdown
Contributor

@ianhattendorf @julianmesa-gitkraken can someone please help us with understanding what do to with the merge requirements (tests that aren't running)? And also we'd like to release a version bump, not sure if there's any special steps there.

There were branch protection rules (https://github.com/Axosoft/nsfw/settings/branches) requiring that the Node 18 tests pass. Since support for Node 18 is being dropped, I've removed those checks.

For releasing: it's a yarn project so you'll want to yarn publish, but with the recent changes to npm I'm not sure if that will work so you might need to fiddle with it.

@Mr-Wallet Mr-Wallet merged commit 91bc7fe into Axosoft:master Mar 16, 2026
10 checks passed
@Mr-Wallet Mr-Wallet deleted the fix/dependabot-alerts branch March 16, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants