docs: add end-to-end SDK app integration blueprint - #419
Merged
El-swaggerito merged 1 commit intoJul 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #283.
This PR adds an end-to-end application integration blueprint showing how mobile and third-party application developers can safely combine the PocketPay SDK’s configuration, diagnostics, wallet, account, payment, transaction, Soroban, vault and error-handling modules.
The existing
docs/app_integration_blueprint.mdplaceholder has been expanded into a complete application-level guide, supported by a typed runnable example and links from the root and examples READMEs.Changes
docs/app_integration_blueprint.mdinto a full integration guide.examples/app-integration-blueprint.tsas a typed end-to-end Testnet example.README.mddocumentation index.examples/README.md.Blueprint coverage
The guide now covers:
The document also includes structured lifecycle and sequence diagrams to show how the SDK modules fit together in a complete application flow.
Security considerations
The blueprint clearly warns consumers not to:
It recommends encrypted device storage, OS keychains, external signers or reviewed backend/HSM boundaries depending on the application architecture.
Testing and verification
Passed
Result: passed.
StellarSDK.BASE_FEEtyping issue insrc/network/fee.ts.git diff --checkpassed.Existing upstream verification failures
The full
npm run verifycommand does not currently pass onupstream/mainbecause of unrelated existing repository issues, including:StellarSDK.BASE_FEEinsrc/network/fee.ts.tests/external_signer.test.ts.PAYMENT_FAILEDandSEND_ERRORinstead of the currentTX_BAD_SEQUENCEandNET_RATE_LIMITEDclassifications.Test result during verification:
None of the failing source or test files are modified by this PR.
Acceptance criteria
Files changed