docs: add reviewer evidence checklist (#498) - #531
Merged
El-swaggerito merged 1 commit intoJul 29, 2026
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a maintainer-facing Reviewer Evidence Checklist so reviewers evaluate whether a PR is complete and evaluation-ready against the same evidence every time, instead of merging on a green checkmark or a convincing description alone.
Every existing checklist in the repo is contributor-facing (Self-Review Checklist, Contributor Self-Assessment, Issue Approval Readiness, Evaluation Readiness). This new doc is the mirror image: it tells the reviewer what to confirm on the diff, the test output, and the CI run itself before approving.
Closes #498
What's included
New doc
docs/reviewer-evidence-checklist.md, covering:npm test,npm run typecheck,npm run lintgreen on the latest commit, plusnpm run api:checkwhere the change touchessrc/types/pocketpay-sdk.d.tsorsrc/sdk-stub/Plus a "Ready To Approve When" gate and cross-links to the related contributor guidance.
Acceptance criteria
docs/reviewer-evidence-checklist.mdNotes
Documentation-only change. No application code, tests, or dependencies are touched.