Docs/448 self review checklist - #516
Merged
El-swaggerito merged 3 commits intoJul 29, 2026
Merged
Conversation
Closes Axionvera#447 Small mobile PRs can change styling or a few lines without actually addressing the requested behaviour in an issue, and merging doesn't mean the work is payment-ready. - Add docs/meaningful-change-guide.md: defines the bar for "meaningful" (requested behaviour, tests, screenshots, accessibility, acceptance criteria), with concrete incomplete-vs-acceptable PR examples drawn from this app's actual screens (Send validation, Receive copy button, Vault lock states) rather than generic examples, required testing evidence, and reviewer expectations. - Cross-links the Evaluation Readiness Checklist, the (forthcoming) Self-Review Checklist, the Screen Test Matrix, and the Accessibility Checklist rather than duplicating their content. - Link the guide from README.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Add a pre-PR self-review checklist covering feature completion, tests, CI, screenshots/recordings, and device or emulator verification, and link it from README, CONTRIBUTING, and the PR template. Also fills the existing self-review-checklist.md link in the meaningful-change guide, which previously pointed nowhere. Closes Axionvera#448
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #
Test Plan and Evidence
Self-Assessment
Before opening this PR, run through the
Self-Review Checklist.
Then complete the
Contributor Self-Assessment before
requesting review. Include concise evidence below; use
Not applicable — <reason>instead of leaving a required area unexplained.or unfinished work.
or a no-test justification is provided.
latest commit.
screenshots, and links are updated, or no update is needed.
and follow-up work are disclosed below.
or verification evidence below.
CI Status
Documentation
Known Limitations
Acceptance Criteria
Screenshots or Recordings