docs: add vault governance model for admin, pause, and immutable config (#407) - #423
Open
jd5073356-max wants to merge 1 commit into
Open
docs: add vault governance model for admin, pause, and immutable config (#407)#423jd5073356-max wants to merge 1 commit into
jd5073356-max wants to merge 1 commit into
Conversation
6 tasks
Contributor
| \nThis PR is currently blocked by merge conflicts.\n\nPlease update the branch with the latest main branch and resolve the conflicts before it can be merged. |
Contributor
| \nGitHub has not finished calculating whether this PR can be merged cleanly.\n\nThe auto-merge automation will skip this PR for now. Re-run the automation later. |
Contributor
|
@jd5073356-max please resolve and fix merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the comprehensive Vault Governance Model specification and security test module for the
SavingsVaultsmart contract as requested in #407.Changes Included
Governance Model Specification (
docs/vault-governance-model.md):Token,Initialized,StorageVersion) vs. mutable admin controls (Admin,Paused,PauseExpiry,MinDepositAmount,MaxLockDurationSecs,MinLockDurationSecs).pauseandunpauselifecycle, auto-unpause on ledger timestamp expiry without manual transaction requirement.depositandlock_fundswhilewithdrawandwithdraw_lockremain non-blocking.Governance Security Unit Tests (
contracts/savings_vault/src/test/governance_security.rs):Upstream Bug Fix & Test Suite Resolution:
token_client.transferexecution inSavingsVault::withdrawthat caused failed withdrawals.Documentation:
docs/vault-governance-model.mdin repositoryREADME.md.Verification
cargo check --tests: Clean compilation.cargo test: 384 passed; 0 failed.Closes #407