fix: drop the backtracking trailing-whitespace regex

[svaningelgem]

Clears the two Sonar findings on master that are worth code changes. 263 tests green.

Fixed — the two MAJOR regex findings

YamlFileInterface:315 and YamlWriter:274 both did line.replaceAll("\\s*$", "") to trim a comment line. Sonar is right that it's super-linear. The stdlib has done this since Java 11 and the project targets 17:

line.replaceAll("\\s*$", "")  ->  line.stripTrailing()

No regex engine, clearer intent, and stripTrailing() uses Character.isWhitespace so it also catches Unicode whitespace that the ASCII-only \s class misses.

Fixed — the MINOR "unused collection", by making the test real

YamlWriterEdgeCaseTests.testNormalizeCollectionWithNonComparableSet built a Set, then asserted on new ArrayList<>(nonComparableSet) — it never called save(), so it covered the JDK's ArrayList constructor rather than normalizeCollection. That's what Sonar's "unused collection" was pointing at.

Rather than delete it, it now does what its name says: saves a Set<Address> (records aren't Comparable) and asserts the insertion order survives, since a set that can't be sorted must be written as it came in.

Verified it actually guards the branch — dropping the instanceof Comparable check from normalizeCollection makes it fail with a ClassCastException rather than pass quietly.

Not changed — two I'd suppress instead

TypeConverter:79, cognitive complexity 21. This is the flat dispatch table deliberately left alone in #143: fourteen sequential if (...) return ...; guards with zero nesting, whose order is the meaning. It was WONTFIX'd before, and only reappeared because #141 shifted its declaration line and Sonar lost the issue↔suppression match. Worth re-marking WONTFIX rather than splitting.

PluginLoggerRoutingTest:63, unused parameter args. VarargsStyleLogger.warning(String, Object...) exists precisely so discoverPluginSink can find that signature by reflection — the unused parameter is the thing under test. Removing it deletes the test's reason to exist. Worth marking false-positive.

Also

Corrected the CoverageBoostTests.testNonComparableSetInYaml comment, which said "UUIDs are Comparable, so let's use a List instead to verify the path" while using a Set<UUID>. It covers the sorting side; the comment now says so and points at the test that covers the other side.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines	Coverage Δ
.../main/java/org/avarion/yaml/YamlFileInterface.java	100.00% <100.00%> (ø)
src/main/java/org/avarion/yaml/YamlWriter.java	100.00% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud