Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes several GitHub Actions workflows and the workflows README under .github/workflows/, leaving publish-core.yml as the only remaining workflow in the repository. As a result, any CI/CD previously handled by the deleted workflows (Web Portal, Asset Store, Docs, and Launcher/test workflows) will no longer run unless there is an external replacement process.
Changes:
- Deleted Azure Static Web Apps deployment workflows for the Web Portal and Asset Store.
- Deleted placeholder/test workflows for Docs and Launcher.
- Removed
.github/workflows/README.mdthat documented the pipeline setup.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/README.md |
Removed pipeline documentation (no replacement added). |
.github/workflows/publish-web.yml |
Removed Web Portal deployment workflow. |
.github/workflows/publish-launcher.yml |
Removed Launcher/test workflow. |
.github/workflows/publish-docs.yml |
Removed Docs publishing workflow. |
.github/workflows/publish-asset-store.yml |
Removed Asset Store deployment workflow. |
.github/workflows/azure-static-web-apps-victorious-moss-06d128203.yml |
Removed auto-generated Azure Static Web Apps CI/CD workflow. |
Comments suppressed due to low confidence (6)
.github/workflows/publish-web.yml:1
- This workflow is being removed entirely, which would disable the GitHub Actions-based deployment for the Web Portal. If deployments are still required, keep a replacement workflow (or document the new deployment mechanism) and update the PR description to explicitly state that Web Portal CI/CD is being decommissioned.
.github/workflows/publish-asset-store.yml:1 - Removing this workflow disables Asset Store CI/CD (including Static Web Apps deployment and PR close cleanup). If Asset Store is still an active component, add a replacement deployment pipeline or move this workflow to a clearly disabled state (e.g., manual dispatch) with documentation explaining why it’s not triggered automatically anymore.
.github/workflows/azure-static-web-apps-victorious-moss-06d128203.yml:1 - This auto-generated Azure Static Web Apps CI/CD workflow is being deleted and there is no other workflow in the repo that deploys the web UI (no remaining uses of Azure/static-web-apps-deploy). If the Static Web App is still meant to be updated from main/PRs, keep an equivalent workflow or document the replacement deployment process in the repo.
.github/workflows/README.md:1 - The workflows documentation (.github/workflows/README.md) is being removed and there doesn’t appear to be any replacement documentation elsewhere in the repo. If these pipelines are still relevant (even if temporarily disabled), move this documentation to a more appropriate location (e.g., /docs or root README) or add an updated replacement so contributors can understand how releases/deployments are supposed to work.
.github/workflows/publish-launcher.yml:1 - The PR description is still “TBD” for both the problem statement and the solution. Given this PR removes multiple CI/CD workflows, please update the PR description to explain the intent (decommission vs. migrate) and what should replace these pipelines operationally.
.github/workflows/publish-docs.yml:1 - Deleting this workflow removes any GitHub Actions path to publish documentation. If docs deployment is still required, add a replacement workflow (or document the new publishing process) so docs updates aren’t silently stopped.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* #109 Engine orchestrator * #128 Cleanup project structure and introduce DI project * #128 Solution builds * #128 Move under core * #128 Add TODO comments * WIP on dev * #128 Use non static reference of GL for proper context usage * #11 Fix texturing * #128 Use MS ILogger * #128 Cleanup DI * #128 Fix startup issue * #128 Fix build errors after merge * #128 Cleanup * #128 Add missing xml docs and cleanup code * #128 Remove Obsolete entities * #128 Model refactoring and cleanup * #109 Add xml docs and cleanup warnings * #109 Add copilot instructions * #109 Add XML documentation and cleanup * #109 Fix windowing and DI * #109 Abstract obj loader --------- Co-authored-by: Antti Veikkolainen <antti.veikkolainen00@outlook.com> Co-authored-by: Antti Veikkolainen <antti.e.veikkolainen@tuni.fi>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<Issue number> <Change title>
Contents
This PR is trying to resolve:
TBD
We resolve it by:
TBD
Checklist
mainto my branch.