Feature/52 av web by Av3boy · Pull Request #119 · Av3boy/SharpEngine

Av3boy · 2025-12-13T13:33:33Z

<Issue number> <Change title>

Checklist

I have merged the latest changes from main to my branch.
I have tested my changes and any affected components.
I have added the proper documentation about my changes
I have made sure there is no overlapping work.
I have discussed any / all issues brought up from code review.

* Temp * Fix * Fix UI element rendering * Use safe code * One more unsafe fix * Added error logging * Basic OpenAL implementation * #16 Remove unnecessary tester project * #26 Editor enhancements * #26 Context menu size fix and documentation * #26 Editor improvements * Method for opening multiple windows * Small refactoring * Opening SharpEngine windows works * UI improvements (WIP) A lot of stuff is unfinished. Context menu locations, launcher styling, xml documentation missing etc. Functionality should be working tho * Launcher UI improvements * Cleanup * Cleanup UIElement mesh data * Cleanup * Texturing improvements * Add basic layout placeholders * UI shader testing (WIP) * UI rendering works * Actual fix * Generalize functions * Fiddle with Transforms and types (WIP) * Midway solution (Not finished) * Getting there * Transform abstraction * UI element ortographic projection * Translating somewhat works * UI transform behaving correctly? * Add documentation / general enhancements * #2 Framing and rendering changes * Pop stash * #26 Fix build * #26 Fix flags * #26 Use width and height * #2 Temp * #2 loop working * #2 Refactoring Introduced obj loader, abstracted some functionality into separate projects, added placeholders for test projects * #2 Cleanup * #2 Separated Shader data container and extension methods * #2 Use correct ui shaders * #2 Fix absolute path bug * #2 Fix build (WIP) * #2 Cleanup * #2 Remove redundant interfaces * #2 More redundant interfaces * #2 More redundancies * #2 simplify data store * #2 Fixing readme details * #2 Simplify call * #2 Quality of life improvements * #2 Use mesh in obj loader * #2 Try map to old format * #2 Use Silk.NET example for debugging purposes * #2 Consolidate new changes * #67 Partial class definition * #2 Use Core Shader in tutorial * #2 Remove redundancies and plan merging * #2 Texture partial class * #2 Improve texture class * #2 Cleanup * #2 More cleanup * #2 Get rid of duplicates * #2 Reorganize content * #2 Using Core data types (Silk example no longer works) * #2 Intermediate state Both test projects work but the Model_Old is still required. * #73 Document issues * #73 Add missing issue links * #2 Use obsolete loader Let's use Model_Old for now to resolve the meshes. Later on once we are implementing the fbx stuff we can try to figure out again how to make the loader properly work. * #2 Using custom meshes in engine works * #2 A very bandaid solution for the obj renderer The implementation works but it's very hacky. This needs to fixed * #2 Cherrypick * #2 Tiny cleanup * #2 Shader issue? * #2 A very slow though "working" solution Textures still missing and the framerate is very bad * #2 Progress! * #2 Pop stash * #2 pop stash * #2 Cleanup IDisposables * #2 Cleanup * #2 Cleanup * #2 Pop stash * #2 A few warnings cleanup * #2 Try clean reliability ratings * #2 Light cleaning up * #2 Cleanup * #2 Fix * #52 gamification (#112) * #52 Modify folder structure * #52 Initial backend project * #52 Initial databases * #52 Temp arch in place --------- Co-authored-by: Antti Veikkolainen <anttiv@recastsoftware.com> --------- Co-authored-by: Antti Veikkolainen <antti.veikkolainen00@outlook.com> Co-authored-by: Antti Veikkolainen <anttiv@recastsoftware.com>

Co-authored-by: Antti Veikkolainen <antti.veikkolainen00@outlook.com>

#52 Fix project structure

on-behalf-of: @Azure opensource@microsoft.com

sonarqubecloud · 2025-12-13T13:35:41Z

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copilot

Pull request overview

This PR introduces web-based UI infrastructure for the SharpEngine project, including a Portal web application, an Asset Store UI, and shared UI components. The changes establish the foundation for web-based interaction with the SharpEngine ecosystem by creating React-based frontends and supporting backend services. However, the PR description is incomplete (marked as TBD), making it difficult to assess whether all intended functionality has been implemented.

Key changes include:

Creation of shared UI component library (sharpengine-ui-shared) for code reuse across web applications
Portal web UI with authentication via Auth0 and basic navigation structure
Asset Store UI with search functionality and asset browsing
Shared C# DTOs and backend infrastructure to support the web applications
Refactoring of project structure to centralize shared code

Reviewed changes

Copilot reviewed 113 out of 163 changed files in this pull request and generated 17 comments.

Show a summary per file

File	Description
Shared/sharpengine-ui-shared/*	New shared React component library with types, API clients, and reusable components
Portal/sharpengine-web-ui/*	New Portal web application with Auth0 integration and navigation
AssetStore/asset-store-ui/*	New Asset Store frontend with search and asset display functionality
Shared/SharpEngine.Shared/*	Refactored shared DTOs moved from Engine to centralized location
Shared/SharpEngine.Rest/*	New REST client infrastructure for API communication
Shared/SharpEngine.Identity/*	New Auth0 client for authentication
Engine/*	Updated project references to use centralized shared code
Portal/Portal.Backend/*	New backend services including Azure Blob storage integration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-13T13:38:47Z

+// TODO: This should be moved to environment variables later since the values may change between environments
+export const Routes =
+{
+    AssetStore: "http://localhost:3000",
+    Portal: "http://localhost:3001",
+}


Hardcoded localhost URLs should be moved to environment variables. This makes it difficult to configure different environments (development, staging, production) and could cause issues when deploying.

Copilot · 2025-12-13T13:38:47Z

+    public string Name { get; set; }
+    public string Url { get; set; }


Properties Name and Url should have default values or be marked as required to prevent null reference issues. Consider using 'required' keyword or providing default values like '= string.Empty;' or '= default!;'.

Copilot · 2025-12-13T13:38:47Z

+    public string Name { get; init; }
+    public string Description { get; init; }


Properties Name and Description should have default values or be marked as required to prevent null reference issues. Consider using 'required' keyword or providing default values like '= string.Empty;' or '= default!;'.

Copilot · 2025-12-13T13:38:47Z

+    public async Task Login()
+    {
+        // TODO: Create user (if not exists) when auth0 login done
+        // We need a copy of the user to link achievements
+    }


The Login method is defined but has no implementation beyond TODO comments. This creates a non-functional service method. Either implement the method properly or remove it if it's not ready for this PR.

Copilot · 2025-12-13T13:38:48Z

+    public UserId UserId { get; init; }
+    public string Username { get; init; } = default!;
+    public string Email { get; init; } = default!;
+    public string Auth0Identifier { get; init; }


The property Auth0Identifier lacks a default value or required modifier, which could lead to null reference issues given that nullable is enabled in the project. Add the required keyword or provide a default value.

Copilot · 2025-12-13T13:38:50Z

+  const [showDropdown, setShowDropdown] = useState(false);
+  const searchRef = useRef<HTMLDivElement>(null);
+
+  const { loginWithRedirect, logout, isAuthenticated, user } = useAuth0();


Unused variable isAuthenticated.

Copilot · 2025-12-13T13:38:50Z

+  const [showDropdown, setShowDropdown] = useState(false);
+  const searchRef = useRef<HTMLDivElement>(null);
+
+  const { loginWithRedirect, logout, isAuthenticated, user } = useAuth0();


Unused variable user.

Copilot · 2025-12-13T13:38:50Z

@@ -0,0 +1,70 @@
+import { useState } from 'react';
+import { useNavigate } from 'react-router-dom';
+import { ChevronDown, User } from 'lucide-react';


Unused import User.

Copilot · 2025-12-13T13:38:50Z

+export function Header() {
+  const navigate = useNavigate();
+  const [isDropdownOpen, setIsDropdownOpen] = useState(false);
+  const [isLoggedIn] = useState(false); // Change this to true to simulate logged in state


Unused variable isLoggedIn.

Copilot · 2025-12-13T13:38:50Z

+
+export function HeaderLogin({ onProfileClicked }: { onProfileClicked: () => void }) {
+
+  const { loginWithRedirect, logout, isAuthenticated, user } = useAuth0();


Unused variable user.

Av3boy and others added 18 commits December 6, 2025 17:21

#52 Fix files (#114)

0be0b7e

Co-authored-by: Antti Veikkolainen <antti.veikkolainen00@outlook.com>

Merge pull request #115 from Av3boy/dev

75debc2

#52 Fix project structure

#52 Add marketing and asset store sites (WIP)

ac5d5b5

#52 Initial UI for websites

b334cce

Small frontend additions

08caf80

Fix README.md links

3b13fba

ci: add Azure Static Web Apps workflow file

65b06b4

on-behalf-of: @Azure opensource@microsoft.com

Merge remote-tracking branch 'origin/main' into feature/52-av-web

1e91e72

#52 Package lock

7ea8caf

#52 Hook yml to feature branch

8436770

#52 Test run pipeline

a10d27f

#52 Remove space from path

cfacaee

#52 Remove step backs

68c35bf

#52 Try ignore warnings

ca194d9

#52 Try fix output

f5b28c5

#52 output test

99d3077

#52 Placeholder pipelines

d5df681

Av3boy self-assigned this Dec 13, 2025

Copilot AI review requested due to automatic review settings December 13, 2025 13:33

Copilot started reviewing on behalf of Av3boy December 13, 2025 13:33 View session

Av3boy merged commit e0ea148 into dev Dec 13, 2025
6 of 8 checks passed

Copilot AI reviewed Dec 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/52 av web#119

Feature/52 av web#119
Av3boy merged 18 commits into
devfrom
feature/52-av-web

Av3boy commented Dec 13, 2025

Uh oh!

sonarqubecloud Bot commented Dec 13, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 13, 2025

Uh oh!

Copilot AI Dec 13, 2025

Uh oh!

Copilot AI Dec 13, 2025

Uh oh!

Copilot AI Dec 13, 2025

Uh oh!

Copilot AI Dec 13, 2025

Uh oh!

Copilot AI Dec 13, 2025

Uh oh!

Copilot AI Dec 13, 2025

Uh oh!

Copilot AI Dec 13, 2025

Uh oh!

Copilot AI Dec 13, 2025

Uh oh!

Copilot AI Dec 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		public string Name { get; set; }
		public string Url { get; set; }

		public string Name { get; init; }
		public string Description { get; init; }


		export function HeaderLogin({ onProfileClicked }: { onProfileClicked: () => void }) {

		const { loginWithRedirect, logout, isAuthenticated, user } = useAuth0();

Conversation

Av3boy commented Dec 13, 2025

<Issue number> <Change title>

Contents

Checklist

Uh oh!

sonarqubecloud Bot commented Dec 13, 2025

Quality Gate failed

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants