🐛 fix(s7comm): correct S7 bit addressing for reads and writes#156
Open
WheelerLee wants to merge 1 commit into
Open
🐛 fix(s7comm): correct S7 bit addressing for reads and writes#156WheelerLee wants to merge 1 commit into
WheelerLee wants to merge 1 commit into
Conversation
Decode S7WLBit Start as an absolute bit offset instead of a byte offset. - resolve the containing byte and bit index for S7WLBit requests - read the containing BOOL byte before Snap7 extracts the requested bit - write only the addressed BOOL instead of unpacking the payload as eight bits - validate BOOL mappings and reject out-of-range bit accesses - preserve existing byte, word and dword access behavior Previously, bit reads and writes could target the same wrong byte, causing readback tests to appear correct. Fixing writes alone exposed the existing read-side addressing error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decode S7WLBit Start as an absolute bit offset instead of a byte offset.
Previously, bit reads and writes could target the same wrong byte, causing
readback tests to appear correct. Fixing writes alone exposed the existing
read-side addressing error.