Skip to content

fix: correct Help release date, local wait loop, and port check#958

Open
Th3BanHamm3r wants to merge 2 commits into
Autonomy-Logic:developmentfrom
Th3BanHamm3r:fix-gui-versioning
Open

fix: correct Help release date, local wait loop, and port check#958
Th3BanHamm3r wants to merge 2 commits into
Autonomy-Logic:developmentfrom
Th3BanHamm3r:fix-gui-versioning

Conversation

@Th3BanHamm3r

@Th3BanHamm3r Th3BanHamm3r commented Jul 23, 2026

Copy link
Copy Markdown

Pull request info

Description of the changes proposed

  • The About tab under Help pins the Release to the npm build date? Release date should be set to the git tag version date.
  • Prevents out of order loading.
  • Wrong port checked in js.

DOD checklist

  • The code is complete and according to developers’ standards.
  • I have performed a self-review of my code.
  • Meet the acceptance criteria.
  • Unit tests are written and green.
  • Test coverage: __ %.
  • Integration tests are written and green.
  • Changes were communicated and updated in the ticket description.
  • Reviewed and accepted by the Product Owner.
  • End-to-end test are successful.

Summary by CodeRabbit

Summary by CodeRabbit

  • Bug Fixes
    • Release builds now use the tagged release’s commit date as the release date.
    • Improved developer startup reliability by waiting for the renderer service to become reachable before starting related tooling.
    • Updated default port checking to use 1313 when no port is specified, reducing “port in use” conflicts.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c01a935b-4d7b-4de4-bdf2-8f56486c2ba7

📥 Commits

Reviewing files that changed from the base of the PR and between db14967 and 897ff92.

📒 Files selected for processing (3)
  • .github/workflows/release.yml
  • package.json
  • scripts/check-port-in-use.js
🚧 Files skipped from review as they are similar to previous changes (3)
  • scripts/check-port-in-use.js
  • package.json
  • .github/workflows/release.yml

Walkthrough

The release workflow now uses tag commit dates for tagged builds, while development startup waits for port 1313 before launching Electron monitoring. Port availability checks also default to port 1313.

Changes

Release date handling

Layer / File(s) Summary
Release date calculation across platform builds
.github/workflows/release.yml
macOS, Windows, and Linux build jobs derive release dates from tag commits for v* tags and use the current date for other runs.

Development startup synchronization

Layer / File(s) Summary
Renderer port and Electron monitoring startup
package.json, scripts/check-port-in-use.js
Development startup waits for port 1313 before launching electronmon, adds wait-on, and makes port checks default to 1313.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Poem

A rabbit stamps the release-date beat,
Tag commits make the timing neat.
Port 1313 begins to glow,
Then Electronmon starts to go.
Hop, hop—builds and dev flows align!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main changes: release date fix, startup wait loop, and port check correction.
Description check ✅ Passed The description covers the main changes and includes the required DOD checklist, with only optional reference details omitted.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/release.yml:
- Line 60: Update each git log release-date command in
.github/workflows/release.yml at lines 60, 174, 244, 325, and 391 to use the
committer-date format specifier %cs instead of the author-date specifier %as,
preserving the existing release-date assignment behavior.
- Around line 59-60: Replace direct GitHub expression interpolation in all five
release.yml sites (.github/workflows/release.yml lines 59-60, 173-174, 243-244,
324-325, and 390-391) with quoted "$GITHUB_REF" and "$GITHUB_REF_NAME"
environment variables, and quote the Git revision passed to git log. Preserve
the existing tag check and release-date behavior.

In `@package.json`:
- Line 26: Replace the POSIX-specific readiness loop in the dev script with a
cross-platform Node-based wait helper or declared cross-platform dependency.
Update the dev command to invoke that helper while preserving the existing
renderer startup and Electron launch sequencing.
- Line 26: Update the readiness check in the dev script to match port 1313 as an
exact listening-port token, preventing matches such as 13130. Preserve the
existing wait loop and electronmon startup behavior while anchoring the ss/grep
pattern or reusing a port-aware checker.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 41b09eca-4406-4b84-8b13-3d9724926bae

📥 Commits

Reviewing files that changed from the base of the PR and between 7ace8eb and 0a635a3.

📒 Files selected for processing (3)
  • .github/workflows/release.yml
  • package.json
  • scripts/check-port-in-use.js

Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
Comment thread package.json Outdated
William Joslin added 2 commits July 24, 2026 13:32
- Update the 'About' tab under Help to set the Release date to the git tag version date instead of the npm build date.
- Implement a temporary while-loop to prevent out-of-order loading during offline/disconnected startup (replacing 'wait-on' which fails offline).
- Fix an incorrect port check in the JavaScript configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant