fix: correct Help release date, local wait loop, and port check#958
fix: correct Help release date, local wait loop, and port check#958Th3BanHamm3r wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughThe release workflow now uses tag commit dates for tagged builds, while development startup waits for port 1313 before launching Electron monitoring. Port availability checks also default to port 1313. ChangesRelease date handling
Development startup synchronization
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yml:
- Line 60: Update each git log release-date command in
.github/workflows/release.yml at lines 60, 174, 244, 325, and 391 to use the
committer-date format specifier %cs instead of the author-date specifier %as,
preserving the existing release-date assignment behavior.
- Around line 59-60: Replace direct GitHub expression interpolation in all five
release.yml sites (.github/workflows/release.yml lines 59-60, 173-174, 243-244,
324-325, and 390-391) with quoted "$GITHUB_REF" and "$GITHUB_REF_NAME"
environment variables, and quote the Git revision passed to git log. Preserve
the existing tag check and release-date behavior.
In `@package.json`:
- Line 26: Replace the POSIX-specific readiness loop in the dev script with a
cross-platform Node-based wait helper or declared cross-platform dependency.
Update the dev command to invoke that helper while preserving the existing
renderer startup and Electron launch sequencing.
- Line 26: Update the readiness check in the dev script to match port 1313 as an
exact listening-port token, preventing matches such as 13130. Preserve the
existing wait loop and electronmon startup behavior while anchoring the ss/grep
pattern or reusing a port-aware checker.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 41b09eca-4406-4b84-8b13-3d9724926bae
📒 Files selected for processing (3)
.github/workflows/release.ymlpackage.jsonscripts/check-port-in-use.js
51b172b to
6ab617f
Compare
- Update the 'About' tab under Help to set the Release date to the git tag version date instead of the npm build date. - Implement a temporary while-loop to prevent out-of-order loading during offline/disconnected startup (replacing 'wait-on' which fails offline). - Fix an incorrect port check in the JavaScript configuration.
6ab617f to
897ff92
Compare
Pull request info
Description of the changes proposed
DOD checklist
Summary by CodeRabbit
Summary by CodeRabbit