fix: resolve Windows path separator and filename collision issues - #195
Open
angleyanalbedo wants to merge 2 commits into
Open
Conversation
wattzor
added a commit
to wattzor/STruCpp
that referenced
this pull request
Jul 27, 2026
Ported relevant parts of Autonomy-Logic#195 and extended the filename-collision fix to the CLI: - Normalize backslashes to forward slashes in DocumentManager workspace folder set/add/remove so mixed Windows path separators do not cause duplicate discovery and false 'Duplicate declaration' diagnostics. - Rename the VS Code extension's generated REPL harness from main.cpp to repl_main.cpp so it no longer overwrites the generated implementation file when the source is named main.st. - Apply the same REPL harness rename in the CLI --build path. - Add enum-to-struct-field assignment regression tests from upstream (Autonomy-Logic#171). Verification: - npm run typecheck clean - npx eslint src/ --quiet clean - npm test 117 files / 2186 passed - Manual CLI --build with main.st now produces both main.cpp and repl_main.cpp and the binary runs. Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Simon Atti <wattimedia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Windows path separator normalization (affects VS Code extension LSP diagnostics):
document-manager.ts: normalized\to/inuriToFilePath,setWorkspaceFolders,addWorkspaceFolders,removeWorkspaceFoldersto fix path dedup comparison failures causing false "Duplicate declaration" errors on WindowsNode.js ESM
import()on Windows (affectsnpm run build):rebuild-libs.mjs,build-iec-types-json.mjs: wrappedresolve()withpathToFileURL()to fix ESM loader rejectingD:\absolute pathsFilename collision (affects g++ linking):
commands.ts: renamed REPL entry frommain.cpptorepl_main.cppto avoid overwriting the generated implementation file when the source file is namedmain.stFiles changed
scripts/rebuild-libs.mjsscripts/build-iec-types-json.mjsvscode-extension/server/src/document-manager.tsvscode-extension/client/src/commands.ts