Update Blaze v3 ad preview options#110460
Open
therocket-gr wants to merge 4 commits intotrunkfrom
Open
Conversation
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://linear.app/a8c/issue/ADS-1030/remove-desktop-template-from-blaze-ad-views
Proposed Changes
Part of https://github.tumblr.net/Tumblr/a8c-dsp/pull/3860
This PR has to be merged first
🤖
html5_v2ads.html5_v3ads, using the tablet preview width for the combined option.Why are these changes being made?
The new DSP
html5_v3Blaze template removes the desktop layout, so Calypso should not offer a separate desktop preview for those ads. Existinghtml5_v2ads still support desktop and should keep the current three-option preview.Testing Instructions
html5_v2ad and open the ad preview modal.html5_v3ad and open the ad preview modal.Local note:
yarn eslint client/my-sites/promote-post-i2/components/campaign-item-details/AdPreviewModal.tsxcould not run in the fresh worktree because Yarn reported the missingnode_modulesstate file.git diff --checkpasses.Pre-merge Checklist