Skip to content

Update Blaze v3 ad preview options#110460

Open
therocket-gr wants to merge 4 commits intotrunkfrom
therocketgr/ADS-1030-calypso-v3-preview
Open

Update Blaze v3 ad preview options#110460
therocket-gr wants to merge 4 commits intotrunkfrom
therocketgr/ADS-1030-calypso-v3-preview

Conversation

@therocket-gr
Copy link
Copy Markdown
Contributor

@therocket-gr therocket-gr commented May 5, 2026

Part of https://linear.app/a8c/issue/ADS-1030/remove-desktop-template-from-blaze-ad-views

Proposed Changes

Part of https://github.tumblr.net/Tumblr/a8c-dsp/pull/3860

This PR has to be merged first

🤖

  • Updates the Blaze ad preview modal to check the template format before deciding which preview device options to show.
  • Keeps the existing Mobile, Tablet, and Desktop preview options for existing html5_v2 ads.
  • Shows only Mobile and Tablet/Desktop for html5_v3 ads, using the tablet preview width for the combined option.

Why are these changes being made?

The new DSP html5_v3 Blaze template removes the desktop layout, so Calypso should not offer a separate desktop preview for those ads. Existing html5_v2 ads still support desktop and should keep the current three-option preview.

Testing Instructions

  • Open a Blaze campaign using an html5_v2 ad and open the ad preview modal.
  • Confirm the modal shows Mobile, Tablet, and Desktop options.
  • Open a Blaze campaign using an html5_v3 ad and open the ad preview modal.
  • Confirm the modal shows Mobile and Tablet/Desktop only.
  • Confirm selecting Tablet/Desktop renders the 500px tablet-sized preview.

Local note: yarn eslint client/my-sites/promote-post-i2/components/campaign-item-details/AdPreviewModal.tsx could not run in the fresh worktree because Yarn reported the missing node_modules state file. git diff --check passes.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented May 5, 2026

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • help-center

To test WordPress.com changes, run install-plugin.sh $pluginSlug therocketgr/ADS-1030-calypso-v3-preview on your sandbox.

@therocket-gr therocket-gr requested a review from j6ll May 5, 2026 14:02
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants