Skip to content

Fix: Allow null block names in core block filter#102

Merged
alecgeatches merged 4 commits into
trunkfrom
alceops/fix-null-core-block-name-fix
May 29, 2026
Merged

Fix: Allow null block names in core block filter#102
alecgeatches merged 4 commits into
trunkfrom
alceops/fix-null-core-block-name-fix

Conversation

@alecgeatches

Copy link
Copy Markdown
Contributor

Description

Fixes #99.

This is a follow-up PR for #100 to fix CI tests from phpcs failures, and to add a comment. See original description in #100:

This updates the synced-pattern inner-block filter to accept the null block names that WordPress can pass for parsed non-block/classic-content fragments. In that case the filter now returns the existing inner blocks unchanged instead of raising a PHP TypeError before the parser can continue.

I also added a focused regression test that calls the filter with a null block name.

Verification: I could not run the WordPress/PHP test suite in this cron profile because php/composer/git are not installed here. I did a static patch check against the current trunk file contents via the GitHub API.

@alecgeatches alecgeatches self-assigned this May 29, 2026
@alecgeatches alecgeatches requested a review from a team as a code owner May 29, 2026 18:21
@alecgeatches alecgeatches merged commit 0e84bb8 into trunk May 29, 2026
4 checks passed
@alecgeatches alecgeatches deleted the alceops/fix-null-core-block-name-fix branch May 29, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants