Blockbase: move button padding styles from ponyfill to theme.json

[madhusudhand]

Changes proposed in this Pull Request:

Moved core/button block padding styles from ponyfill to theme.json so that global styles can be configured.

Screenshots

Editor:

Frontend:

Related issue(s):

Fixes: #5856
Related: #5847

[scruffian]

My main concern with this is that the search and file blocks also match the same button style. I'm trying to introduce a button element block to help deal with that: WordPress/gutenberg#40260

[pbking]

Funny, I thought I had left comments on this already.

I also wanted to note that the 'outline' styles of the button don't follow the padding rules, however leveraging styling buttons "The Blockbase Way" does. Here is an example from this branch (with padding set to 35 px):

Also this behavior won't work as expected in any of the Blockbase children. This is Quadrat in regular then hover:

That's in addition to the "other non-block buttons" that @scruffian mentions. I do think that the button element could definitely help that out, but we also have the hover state management that needs to be dealt with, as well as rolling those details into block styles (such as the outline style) that needs to be figured out and dealt with as well before we can move on from this method of button styling in Blockbase.

[madhusudhand]

@pbking addressed the issues in blockbase and in the child themes.
To verify the approach, committed changes related to single child theme quadrat.

All other themes needs to be compiled and verified.

Blockbase

Quadrat

[madhusudhand]

Similar to other block themes, I moved the button hover styles to blockbase/style.css in blockbase.

However, these styles are not getting applied to child themes such as quadrat
Updated blockbase/functions.php, but still it doesn't work.
What am I missing here?

[pbking]

Similar to other block themes, I moved the button hover styles to blockbase/style.css in blockbase.

Anything that Blockbase needs to make available to child themes should still reside in ponyfill.css. The only change we should be making to support this is what css is in ponyfill, not where it is.

[pbking]

All other themes needs to be compiled and verified.

Any changes that require child themes to change isn't a change we can make for Blockbase. There are an unknown number of themes outside of Automattic (and even inside Automattic not under our management) that would need to change. So any changes we make to Blockbase (at this point) should not require changes to child themes.
That does limit what changes we can make, for sure, but that's the cost of being a "parent theme" I think.

[pbking]

@madhusudhand I took a look at this and I'm not sure why I was opposed earlier. The changes to the child themes are reasonable. I'm knocking this branch about and it's the best fix. Thank you for working on this.

I'll push the change rebuilding the rest of the child themes css.

[pbking]

Closing: Work merged in #6167