Create Pendant Base Theme#5694
Conversation
jffng
left a comment
jffng
left a comment
There was a problem hiding this comment.
Couple nits but I think this is good to bring in and iterate, awesome that it was bootstrapped by create block theme 🚢
| @@ -0,0 +1,15 @@ | |||
| <?php | |||
| /** | |||
| * Pattern Name: A 404 page | |||
There was a problem hiding this comment.
We don't register this so an empty pattern shows up in the site editor. I think it's fine to do this in a follow-up, unless you wanted to do it now...
There was a problem hiding this comment.
We're still waiting for this to land at which point this should start working. It doesn't work now but I hope it will before we start in on patterns (and the 404 page). This was copied from @MaggieCabrera 's new boilerplate theme.
My 'druthers is to bring it in now.
There was a problem hiding this comment.
The pattern PR in GB is going to be merged soon, and it most likely will make it to dotcom before the theme is ready to launch, but we can of course make a patch in the meantime.
Co-authored-by: Jeff Ong <jonger4@gmail.com>
Co-authored-by: Jeff Ong <jonger4@gmail.com>
Co-authored-by: Jeff Ong <jonger4@gmail.com>
3 participants
Cloned 'Block Canvas' via the Create Block Theme plugin and adjusted the palette colors as a starting point for Pendant.
This closes #5683
This also closes #5688
Currently this looks a LOT like Blockbase. That is expected.