Blockbase: fixed spacing for header wide#5472
Conversation
scruffian
left a comment
There was a problem hiding this comment.
LGTM. Should the top of the navigation also align with the top of the site title?
I'm not sure if that would affect other stuff (the logo, the mobile behavior...) without adding extra CSS. In any case, @kjellr what do you think about the header as it stands on this PR? |
|
I think we can merge this either way... |
I would like it to, yes. If it's going to take CSS though, I'd rather we just removed the tagline to achieve that alignment. Aside from that, is it possible to extend custom blockGap to the social links too? They don't need the same giant spacing as the rest of the nav, but just a little bit more would be good. They look a little cramped currently. |
|
For the social links CSS would be needed since we are using Blockbase, I'm going to merge all Skatepark PRs and then make a new one on top of them that removes Blockbase as a parent, then we can cover the header issues again. |
|
Looking at this some more, I noticed that the block itself actually has a blockGap setting. I think we should try to get this fixed, so I am suggesting WordPress/wordpress-develop#2307 |
Changes proposed in this Pull Request:
Header wide is used exclusively by Skatepark by default. The spacing between the items was too tight, this was caused by the gap value on Skatepark being too small compared to other themes.
I removed an extra CSS rule on Blockbase that adds gap to the navigation, this is no longer necessary after the latest changes to the block. I tested on other themes and neither where affected by this change.
Before:
After:

Related issue(s):
#5471