Remove ui-desks interface#3852
Draft
shaunandrews wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@studio/uirenderer.tldraw, along with stale UI-mode flags and user-facing desk wording.Most of this PR is deletion. The main new logic is the
06-remove-desks-configmigration, which removes obsolete top-leveldesksdata from the Desktop app config after the ui-desks interface is gone.The migration:
app.jsonexists and has an own top-leveldesksproperty.lockAppdata()before writing.desks, and preserves the rest of the file.unlockAppdata()infinally, including write failures.The focused tests cover:
needsToRun()returning true only whendesksexists.deskswhile preserving unrelated app config.Do we want the migration at all?
Keeping it makes the removal tidy by deleting orphaned ui-desks state from
app.json. Removing it would make this PR closer to a pure code deletion, and may be reasonable because only a small number of people likely used ui-desks and any saved desk data is unlikely to be worth preserving or explicitly cleaning up. The staledeskskey would be inert once the interface and IPC/storage paths are gone.