Add link context in avatar alt#153
Open
obenland wants to merge 2 commits into
Open
Conversation
obenland
force-pushed
the
add/meaningful-alt
branch
from
59b65f5 to
9f23e57
Compare
There was a problem hiding this comment.
Pull request overview
Improves accessibility for author avatar links in the post and post-edit templates by giving the linked avatar image a meaningful alt text (using the existing data.author.urlTitle string as link context), aligning with the referenced Trac accessibility guidance.
Changes:
- Set the author avatar
<img>altattribute to{{ data.author.urlTitle }}in the main post template. - Set the author avatar
<img>altattribute to{{ data.author.urlTitle }}in the post-edit template.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| inc/tpl/post.php | Adds link-context alt text to the linked author avatar image. |
| inc/tpl/post-edit.php | Adds link-context alt text to the linked author avatar image in edit UI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <# if ( ! data.isPage && o2.options.showAvatars && data.author.avatar ) { #> | ||
| <a href="{{ data.author.url }}" title="{{ data.author.urlTitle }}" class="author-avatar {{ data.author.modelClass }}"> | ||
| <img src="{{ data.author.avatar }}" alt="" width="{{ data.author.avatarSize }}" height="{{ data.author.avatarSize }}" class="avatar {{ data.author.modelClass }}" /> | ||
| <img src="{{ data.author.avatar }}" alt="{{ data.author.urlTitle }}" width="{{ data.author.avatarSize }}" height="{{ data.author.avatarSize }}" class="avatar {{ data.author.modelClass }}" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a linked image the alt attribute is actually the link textual content.
See https://meta.trac.wordpress.org/ticket/3371#comment:19