Blaze: rename Advertising to Blaze Ads, move under the Jetpack menu, add migration notice#49584
Blaze: rename Advertising to Blaze Ads, move under the Jetpack menu, add migration notice#49584jjolmo wants to merge 3 commits into
Conversation
…add migration notice Implements the revised ADS-796 plan agreed in April: - Rename the menu label from Advertising to Blaze Ads (product name, not translatable) - Move the menu from Tools to Jetpack (or WooCommerce Marketing when present), registering through Admin_UI\Admin_Menu to avoid the Simple Sites hookname race condition that forced the revert of #47582 - Leave a temporary migration notice entry at Tools pointing to the new location (Jetpack Forms / Stats move pattern), removable via filter and planned for deletion ~1 month after deploy - Redirect the legacy tools.php?page=advertising URL to admin.php - No campaign-based top-level menu promotion (dropped per P2 feedback)
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 2 files.
|
Fixes ADS-796 (supersedes #47858, reapply of #47582 with the revised scope)
Proposed changes
Admin_UI\Admin_Menu::add_menu()to avoid the page-hookname race condition on WordPress.com Simple sites that forced the revert of Rename Advertising to Blaze Ads, add context-aware menu and campaign promotion #47582 (the Jetpack top-level menu is created at priority 1000, after this package's priority-999 registration).jetpack_blaze_show_migration_noticefilter. A follow-up PR will remove it ~1 month after deploy.tools.php?page=advertisingURL toadmin.php?page=advertising, only when the menu has actually moved.jetpack_blaze_menu_slug/jetpack_blaze_menu_label/jetpack_blaze_menu_parentfilters so the standalone Blaze Ads plugin can customize the registration.automattic/jetpack-admin-uidependency in the blaze package and refresh the affected plugin lock files.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
admin.php?page=advertising, and Tools shows a temporary "Blaze Ads" entry rendering the moved notice with a working button.tools.php?page=advertisingredirects toadmin.php?page=advertising.admin.php?page=advertising(regression check for the Rename Advertising to Blaze Ads, add context-aware menu and campaign promotion #47582 revert).jetpack test php packages/blaze(83 tests green locally).