Notifications: make the v3 panel the default#49577
Open
arthur791004 wants to merge 1 commit into
Open
Conversation
Drop the `notifications=v3` query-param opt-in and always render the v3 notifications panel (wpnt-notes-panel3). The query param never shipped, so update its unreleased changelog entry in place. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Graduates the v3 notifications panel to the default. Previously v3 was gated behind a
notifications=v3query parameter; this drops the opt-in and always renders the v3 panel (wpnt-notes-panel3).The query-param opt-in never shipped, so its unreleased changelog entry is updated in place rather than stacking an add + remove pair.
A small follow-up will remove the now-dead v2-panel code (e.g. inlining the constant
$panel_idand dropping itsesc_attrwrapper).Does this pull request change what data or activity we track or use?
No.
Testing instructions
wpnt-notes-panel3(the v3 panel) without needing?notifications=v3in the URL.🤖 Generated with Claude Code