WOOA7S-1497: add Videos widget backed by Jetpack Stats#49573
Draft
Nikschavan wants to merge 9 commits into
Draft
WOOA7S-1497: add Videos widget backed by Jetpack Stats#49573Nikschavan wants to merge 9 commits into
Nikschavan wants to merge 9 commits into
Conversation
Private, source-consumed copy of @wordpress/grid until core publishes it.
Private, source-consumed copy of @wordpress/widget-primitives until core publishes it.
Private, source-consumed dashboard engine; depends on jetpack-widget-primitives and jetpack-grid.
Renders the WidgetDashboard engine via wp-build, bundling the grid/primitives/dashboard packages.
useWidgetTypes drives discovery via /wp/v2/widget-modules; hello-world builds as a lazy-loaded script module.
Hook the page boot-dependencies filter so widget modules reach the import map; move the endpoint to the jetpack/v4 namespace.
@wordpress/grid and widget-primitives references in widget-dashboard JSDoc/comments/README, per the faithful-source sync policy.
Adds a Videos dashboard widget showing most played videos via the stats-admin REST proxy, with a shared stats query in the data package. Also centers chart empty states across the full widget width and renders React Query devtools once at the page level instead of per widget.
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
d060b2d to
5bb6dd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Ports the Videos widget from the Jetpack Stats module into the Premium Analytics dashboard, backed by the Jetpack Stats API.
stats-fetchAPI client that goes through the stats-admin proxy (/jetpack/v4/stats-app/sites/{blog_id}/stats/{resource}), plusstatsQuery/statsVideoPlaysQueryquery builders anduseStatsVideoPlays/useStatsBlogIdhooks. The blog ID is resolved once from/jetpack/v4/connection/dataand cached for the page lifetime; queries useskipTokenwhile the blog ID or report date is unresolved.VideosWidget(leaderboard chart of most played videos with comparison support) and abuildVideoPlaysDatahelper, with loading/refetching overlays and empty/error states.jpa/videosdashboard widget (render entry,widget.json,widget.tswith a configurablemaxattribute). The render entry defaults to an all-time report range until the host can pass the site launch date.withDevtoolsprop so React Query devtools render once at the page level instead of per widget.videoicon used for the chart empty state.Note: the diff also carries the "add dynamic widget registry and REST endpoint" commit until the base branch catches up with it.
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
/jetpack/v4/stats-app/sites/{blog_id}/stats/video-plays).Maximum videosattribute and verify the list respects the limit.