Skip to content

Write: use progress cursor on Save buttons while saving#49566

Merged
allilevine merged 1 commit into
trunkfrom
fix/rsm-4006-save-button-cursor
Jun 12, 2026
Merged

Write: use progress cursor on Save buttons while saving#49566
allilevine merged 1 commit into
trunkfrom
fix/rsm-4006-save-button-cursor

Conversation

@allilevine

@allilevine allilevine commented Jun 11, 2026

Copy link
Copy Markdown
Member

Fixes RSM-4006

Proposed changes

  • While a save is in flight in the Write editor, the Save Draft and Publish buttons get disabled (via data-wp-bind--disabled="state.isSaving"). The shared .bw-btn:disabled rule was applying cursor: not-allowed, which is the affordance for "this action is forbidden" — wrong for an in-flight save that is actually succeeding. Switched to cursor: progress to match the existing .bw-upload-zone.bw-uploading precedent.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • Open a Write editor draft (/write on a WP.com site running this build).
  • Type something to make the draft dirty.
  • Click Save draft (or Publish / Update).
  • While the save is in flight, hover the button: the cursor should now show the "progress" / busy indicator (platform-dependent — typically an arrow with a spinner) instead of the "no entry" / forbidden cursor.
  • The save itself should complete normally.

Note: the in-flight window is brief — easiest to observe on a slow network (devtools → Network → Slow 3G) or on a longer post.

The Save Draft and Publish buttons are briefly disabled while a save is
in flight (via state.isSaving), and .bw-btn:disabled was applying
cursor: not-allowed. That's the wrong affordance: the action is
succeeding, just in progress — matching the existing .bw-uploading
pattern, we now use cursor: progress for the in-flight state.
@allilevine allilevine self-assigned this Jun 11, 2026
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the fix/rsm-4006-save-button-cursor branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/rsm-4006-save-button-cursor

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jun 11, 2026
@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@allilevine allilevine merged commit 3e13100 into trunk Jun 12, 2026
75 checks passed
@allilevine allilevine deleted the fix/rsm-4006-save-button-cursor branch June 12, 2026 17:30
@github-actions github-actions Bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant