Skip to content

Google Fonts: mark feature as Beta and remove from dashboard.#23713

Merged
samiff merged 1 commit into
masterfrom
update/google-fonts-beta
Mar 30, 2022
Merged

Google Fonts: mark feature as Beta and remove from dashboard.#23713
samiff merged 1 commit into
masterfrom
update/google-fonts-beta

Conversation

@jeherve

@jeherve jeherve commented Mar 30, 2022

Copy link
Copy Markdown
Member

Follow-up from #23295

Changes proposed in this Pull Request:

  • The feature is still under development, and we'll need to make some more changes before it's ready for prime-time. Let's make that clear in the plugin by marking the module as beta and removing the toggle from the dashboard to avoid setting wrong expectations.

Jetpack product discussion

  • Internal reference: p1HpG7-flD-p2#comment-53417

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Go to Jetpack > Settings > Writing, and scroll down to the Theme Enhancements section; you should not see a section about Google Fonts.
  • Go to Jetpack > Modules (from the link at the bottom of the dashboard page). You should see the Google Fonts module, but with a Beta label.

Follow-up from #23295

The feature is still under development, and we'll need to make some more changes before it's ready for prime-time. Let's make that clear in the plugin by marking the module as beta and removing the toggle from the dashboard to avoid setting wrong expectations.

Internal reference: p1HpG7-flD-p2#comment-53417
@jeherve jeherve added this to the jetpack/10.8 milestone Mar 30, 2022
@jeherve jeherve added Admin Page React-powered dashboard under the Jetpack menu [Package] Google Fonts Provider This package no longer exists in the monorepo. [Pri] Normal [Status] Needs Cherry-Pick [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Mar 30, 2022
@jeherve jeherve self-assigned this Mar 30, 2022
@github-actions github-actions Bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Mar 30, 2022
@github-actions

github-actions Bot commented Mar 30, 2022

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: April 5, 2022.
  • Scheduled code freeze: March 29, 2022.

@samiff samiff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

  • Toggle removed on Dashboard.
  • Was able to control the setting from jetpack_modules page.
  • Google Fonts still applied from Global styles as expected.

@samiff samiff merged commit 879b1d7 into master Mar 30, 2022
@samiff samiff deleted the update/google-fonts-beta branch March 30, 2022 19:20
@github-actions github-actions Bot removed the [Status] Needs Review This PR is ready for review. label Mar 30, 2022
samiff pushed a commit that referenced this pull request Mar 30, 2022
…hboard. (#23713)

Follow-up from #23295

The feature is still under development, and we'll need to make some more changes before it's ready for prime-time. Let's make that clear in the plugin by marking the module as beta and removing the toggle from the dashboard to avoid setting wrong expectations.

Internal reference: p1HpG7-flD-p2#comment-53417
@samiff

samiff commented Mar 30, 2022

Copy link
Copy Markdown
Contributor

cherry-picked to jetpack/branch-10.8 in 92df9b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu [Package] Google Fonts Provider This package no longer exists in the monorepo. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants