This repository was archived by the owner on Apr 3, 2023. It is now read-only.
Fix templates on mobile#142
Merged
Merged
Conversation
gabrielcaires
approved these changes
Dec 5, 2022
gabrielcaires
left a comment
Contributor
There was a problem hiding this comment.
I checked all templates and all of them seem working well on mobile and desktop, I just found that the blockGap configuration is causing some issues on the patterns like this one:
But I think we should fix it on other PRs because it seems like the correct way to do it.
We also have an issue with the margin-bottom (same image, space between the green background and the green line, but I also think it is another PR.
Member
Author
Mikey from Team Zen already submitted PRs for the testimonial spacing issues in both the theme and plugin. And I'd though you submitted a PR for the other issue? 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The accepted way of setting site-wide padding is to use the
useRootPaddingAwareAlignmentstheme setting. Enabling this setting adds default padding as specified insettings.styles.spacing.paddingoftheme.json. Then, any blocks that have thealignfullclass will automatically have a negative margin applied by that same amount so that the block extends to the edges of the browser. (We can also use this for setting top and bottom padding in the future.)More details about how this works can be found here and here.
Testing Instructions
alignfullextend from edge to edge of the browser (i.e. they have no left or right padding).