Skip to content

Fix pending chat run-control states #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chubes4 merged 1 commit into from
Jun 18, 2026
+84 −10
Merged

Fix pending chat run-control states #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/Channels/register-agents-chat-ability.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,23 @@ function agents_chat_dispatch( array $input ) {
WP_Agent_Chat_Run_Control::start_run( $result_run_id, $resolved_session_id, array( 'agent' => $agent ) );
}

$status = ! empty( $result['completed'] ) || ! array_key_exists( 'completed', $result )
? WP_Agent_Chat_Run_Control::STATUS_COMPLETED
: WP_Agent_Chat_Run_Control::STATUS_RUNNING;
$result_status = WP_Agent_Chat_Run_Control::normalize_status( $result['status'] ?? '' );
if ( WP_Agent_Chat_Run_Control::STATUS_FAILED === $result_status ) {
$status = WP_Agent_Chat_Run_Control::STATUS_FAILED;
} elseif ( ! empty( $result['completed'] ) || ! array_key_exists( 'completed', $result ) ) {
$status = WP_Agent_Chat_Run_Control::STATUS_COMPLETED;
} elseif ( in_array(
$result_status,
array(
WP_Agent_Chat_Run_Control::STATUS_RUNTIME_TOOL_PENDING,
WP_Agent_Chat_Run_Control::STATUS_APPROVAL_REQUIRED,
),
true
) ) {
$status = $result_status;
} else {
$status = WP_Agent_Chat_Run_Control::STATUS_RUNNING;
}
WP_Agent_Chat_Run_Control::finish_run( $result_run_id, $status );
}

Expand Down
18 changes: 11 additions & 7 deletions src/Runtime/class-wp-agent-chat-run-control.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,15 @@
*/
class WP_Agent_Chat_Run_Control {

public const STATUS_QUEUED = 'queued';
public const STATUS_RUNNING = 'running';
public const STATUS_CANCELLING = 'cancelling';
public const STATUS_CANCELLED = 'cancelled';
public const STATUS_COMPLETED = 'completed';
public const STATUS_FAILED = 'failed';
private const OPTION_KEY = 'agents_api_chat_run_control';
public const STATUS_QUEUED = 'queued';
public const STATUS_RUNNING = 'running';
public const STATUS_CANCELLING = 'cancelling';
public const STATUS_CANCELLED = 'cancelled';
public const STATUS_COMPLETED = 'completed';
public const STATUS_FAILED = 'failed';
public const STATUS_RUNTIME_TOOL_PENDING = 'runtime_tool_pending';
public const STATUS_APPROVAL_REQUIRED = 'approval_required';
private const OPTION_KEY = 'agents_api_chat_run_control';

/** @return string[] */
public static function statuses(): array {
Expand All @@ -31,6 +33,8 @@ public static function statuses(): array {
self::STATUS_CANCELLED,
self::STATUS_COMPLETED,
self::STATUS_FAILED,
self::STATUS_RUNTIME_TOOL_PENDING,
self::STATUS_APPROVAL_REQUIRED,
);
}

Expand Down
56 changes: 56 additions & 0 deletions tests/chat-run-control-smoke.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,62 @@ static function ( $handler, array $input ) use ( &$captured_chat_input ) {
$stored = AgentsAPI\AI\Channels\agents_get_chat_run( array( 'session_id' => 'session-1', 'run_id' => $chat['run_id'] ) );
agents_api_smoke_assert_equals( 'completed', $stored['status'] ?? null, 'chat dispatch records completed run by default', $failures, $passes );

add_filter(
'wp_agent_chat_handler',
static fn() => static fn( array $runtime_input ): array => array(
'session_id' => $runtime_input['session_id'],
'run_id' => $runtime_input['run_id'],
'reply' => '',
'completed' => false,
'status' => 'runtime_tool_pending',
'runtime_tool_pending' => array(
'tool_name' => 'client/summarize',
'tool_call_id' => 'call-pending-1',
),
),
20,
2
);

$pending_chat = AgentsAPI\AI\Channels\agents_chat_dispatch(
array(
'agent' => 'demo-agent',
'message' => 'Needs runtime tool',
'session_id' => 'session-pending',
)
);
$pending_stored = AgentsAPI\AI\Channels\agents_get_chat_run( array( 'session_id' => 'session-pending', 'run_id' => $pending_chat['run_id'] ) );
agents_api_smoke_assert_equals( 'runtime_tool_pending', $pending_stored['status'] ?? null, 'chat dispatch keeps runtime-tool pending run addressable', $failures, $passes );
agents_api_smoke_assert_equals( false, 'completed' === ( $pending_stored['status'] ?? null ), 'runtime-tool pending run is not marked completed', $failures, $passes );

add_filter(
'wp_agent_chat_handler',
static fn() => static fn( array $runtime_input ): array => array(
'session_id' => $runtime_input['session_id'],
'run_id' => $runtime_input['run_id'],
'reply' => '',
'completed' => false,
'status' => 'approval_required',
'approval_required' => array(
'type' => 'approval_required',
'payload' => array( 'action_id' => 'approve-1' ),
),
),
30,
2
);

$approval_chat = AgentsAPI\AI\Channels\agents_chat_dispatch(
array(
'agent' => 'demo-agent',
'message' => 'Needs approval',
'session_id' => 'session-approval',
)
);
$approval_stored = AgentsAPI\AI\Channels\agents_get_chat_run( array( 'session_id' => 'session-approval', 'run_id' => $approval_chat['run_id'] ) );
agents_api_smoke_assert_equals( 'approval_required', $approval_stored['status'] ?? null, 'chat dispatch keeps approval-required run addressable', $failures, $passes );
agents_api_smoke_assert_equals( false, 'completed' === ( $approval_stored['status'] ?? null ), 'approval-required run is not marked completed', $failures, $passes );

AgentsAPI\AI\WP_Agent_Chat_Run_Control::start_run( 'run-default-cancel', 'session-1' );
$default_cancelled = AgentsAPI\AI\Channels\agents_cancel_chat_run( array( 'session_id' => 'session-1', 'run_id' => 'run-default-cancel' ) );
agents_api_smoke_assert_equals( 'cancelling', $default_cancelled['status'] ?? null, 'default cancel marks running runs as cancelling', $failures, $passes );
Expand Down
Loading