Added 2D flow over cylinder example#162
Open
hsalehipour wants to merge 2 commits into
Open
Conversation
massimim
approved these changes
May 29, 2026
Collaborator
massimim
left a comment
massimim
left a comment
There was a problem hiding this comment.
@hsalehipour, the PR looks good. I just lest some minor comments.
Thank you!
|
|
||
| Compute backends | ||
| ---------------- | ||
| * **WARP (default):** Recommended for large 2D GPU runs. |
Collaborator
There was a problem hiding this comment.
The list of backends excludes Neon. Is there a specific reason?
| # -------------------------- Simulation Setup -------------------------- | ||
|
|
||
| diam = 80 # Cylinder diameter in lattice units; reduce (e.g. 20) for faster runs | ||
| reference_diam = 80 |
Collaborator
There was a problem hiding this comment.
I think some comments would help highlight the need for a second variable for the diameter.
Comment on lines
+97
to
+99
| grid_shape = (int(22 * diam), int(4.1 * diam)) | ||
| cylinder_center = (2.0 * diam, 2.0 * diam) | ||
| cylinder_radius = diam / 2.0 |
Collaborator
There was a problem hiding this comment.
I'd move these after line 88 to keep all geometric parameters in the same place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributing Guidelines
Description
Added 2D flow over cylinder example requested in #144 and fixed some error reporting bugs in `operator.py'
Type of change
How Has This Been Tested?
Linting and Code Formatting
Make sure the code follows the project's linting and formatting standards. This project uses Ruff for linting.
To run Ruff, execute the following command from the root of the repository:
ruff check .