Fix in non-ANSI language, status board cannot be shown#18
Open
Zipher04 wants to merge 3 commits into
Open
Conversation
Add a new class "status_code_order". Which return the status code in order of the status defined in the plugin configuration.
The statusNameL may contain non-ANSI characters, which cannot be used as array index. The status code is get from PHP directly.
Owner
|
Hi, @Zipher04 ! |
Contributor
Author
|
Hello, @AuthenticEshkinKot |
|
|
||
| foreach( $status_name as $t_name ) { | ||
| for ( $i = 0 ; $i < sizeof($t_status_array) ; $i++ ){ | ||
| if ( 0 == strcmp($t_name, $t_status_array[$i][1]) ){ |
Owner
There was a problem hiding this comment.
You're trying to compare status name from mantis ($t_status_array[$i][1], from config_get( 'status_enum_string' )), that is always english, and localized status name ($t_name, from $status_order), that may be on any other language. In such a case, this code compare will never return "true".
There was a problem hiding this comment.
@Zipher04
Would you like to fix it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The statusNameL may contain non-ANSI characters, which cannot be used as array index.
The status code needed for m_statusByColumns is directly calculated by PHP.