feat: remind SBP bundle users when they change their emails#278
Merged
amandazhuyilan merged 3 commits intoJun 11, 2026
Conversation
Merged
5 tasks
marius-mather
requested changes
Jun 11, 2026
marius-mather
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, just want to clarify how we record the revocation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SBP-398: Auto-revoke SBP bundle when a user changes to a non-institutional email
Changes
POST /me/profile/email/continue), if the user holds an approved SBP bundle and the new email is non-institutional, automatically revoke the bundle and its backing Auth0 role (via existingGroupMembership.revoke()).check_australian_research_institution_email()returning True/False/None; revocation only fires on a definitive non-institutional result — an indeterminate result (e.g. upstream outage) is logged and left untouched, so a transient failure never wrongly strips access.is_australian_research_institution_email()now delegates to the tri-state helper; its False-on-error contract (used by registration/request gates) is unchanged.biocommons.org.authat was whitelisted in the Australian Institutional list previously - now its addedRelated front end changes: AustralianBioCommons/aai-portal#244
Checklist
How to Test Manually (if necessary)
uv run pytest