fix: staging email not delivered#274
Merged
Merged
Conversation
marius-mather
approved these changes
May 28, 2026
marius-mather
left a comment
Collaborator
There was a problem hiding this comment.
yep, looks like a nice way to do this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix: Scheduler crashes after sending emails (staging emails not delivered)
Problem
The email scheduler was silently dying after attempting to send any email. This caused all subsequent emails to never be processed.
Changes
scheduled_tasks/scheduler.py— Added a dedicated"email",MemoryJobStorealongside the existing SQLAlchemy default storescheduled_tasks/tasks.py— One-shot email delivery jobs now usejobstore="email"(in-memory) instead of the SQLAlchemy storeWhy this works
EmailNotificationtable already tracks all email state (PENDING→SENDING→SENT/FAILED).process_email_queue,cleanup_email_otps) are unaffected and continue using the PostgreSQL job store.Checklist