Skip to content

Fix/address todos#457

Open
oscar24357 wants to merge 5 commits into
Austinaminu2:mainfrom
oscar24357:fix/address-todos
Open

Fix/address todos#457
oscar24357 wants to merge 5 commits into
Austinaminu2:mainfrom
oscar24357:fix/address-todos

Conversation

@oscar24357

@oscar24357 oscar24357 commented Apr 25, 2026

Copy link
Copy Markdown

closes #398

- Synchronize README.md event tables with source code
- Add missing forge-vesting-factory event documentation
- Create CONTRIBUTING.md to fix broken documentation links
- Comment out broken bench target in Makefile
- Correct forge-stream function signature in README.md

@oscar24357 oscar24357 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closes #398

- Adopt new contract location (contracts/) and shared error library (crates/forge-errors)
- Merge CONTRIBUTING.md with detailed setup and pre-commit hook instructions
- Update workspace Cargo.toml with new member paths
- Preserve README.md event documentation and function signature fixes
@drips-wave

drips-wave Bot commented Apr 25, 2026

Copy link
Copy Markdown

@oscar24357 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve TODO Comments

1 participant