This repository was archived by the owner on Oct 6, 2020. It is now read-only.
Vision code - #1
Open
zsim314 wants to merge 11 commits into
Open
Conversation
azvanderpas
reviewed
Jan 15, 2020
azvanderpas
reviewed
Jan 16, 2020
azvanderpas
reviewed
Jan 16, 2020
azvanderpas
reviewed
Jan 16, 2020
azvanderpas
reviewed
Jan 16, 2020
Comment on lines
+1
to
+6
| /*----------------------------------------------------------------------------*/ | ||
| /* Copyright (c) 2018-2019 FIRST. All Rights Reserved. */ | ||
| /* Open Source Software - may be modified and shared by FRC teams. The code */ | ||
| /* must be accompanied by the FIRST BSD license file in the root directory of */ | ||
| /* the project. */ | ||
| /*----------------------------------------------------------------------------*/ |
There was a problem hiding this comment.
Is this file going to be used in the future? If not, delete
azvanderpas
reviewed
Jan 16, 2020
azvanderpas
reviewed
Jan 16, 2020
azvanderpas
reviewed
Jan 16, 2020
azvanderpas
reviewed
Jan 16, 2020
Comment on lines
+47
to
+49
| // Called every time the scheduler runs while the command is scheduled. | ||
| @Override | ||
| public void execute() { |
There was a problem hiding this comment.
This functions needs comments to explain where the adjust numbers are coming from, and what tx maps to on the limelight.
azvanderpas
reviewed
Jan 16, 2020
azvanderpas
reviewed
Jan 16, 2020
azvanderpas
reviewed
Jan 16, 2020
azvanderpas
reviewed
Jan 16, 2020
azvanderpas
reviewed
Jan 16, 2020
azvanderpas
reviewed
Jan 16, 2020
azvanderpas
reviewed
Jan 16, 2020
azvanderpas
reviewed
Jan 16, 2020
AndrewIverson
suggested changes
Jan 16, 2020
AndrewIverson
approved these changes
Jan 18, 2020
azvanderpas
suggested changes
Jan 18, 2020
azvanderpas
suggested changes
Jan 18, 2020
… dont look at the name of the file woops
AndrewIverson
suggested changes
Jan 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vision code