Skip to content

fix(shell): one-past-the-end write in argv array when a command has MAX_CMD_ARGS tokens #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
im-nymii merged 1 commit into from
Jul 24, 2026
Merged

fix(shell): one-past-the-end write in argv array when a command has MAX_CMD_ARGS tokens #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/kernel/shell.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ void debug_trigger_page_fault(void) {
}

static void shell_execute(char *cmd) {
char *args[MAX_CMD_ARGS];
char *args[MAX_CMD_ARGS + 1]; // +1 for the NULL terminator written by shell_parse
int argc = shell_parse(cmd, args);
if (argc == 0)
return;
Expand Down
Loading