refactor: Extract audio logic into AudioController#7
Open
codingWiz-rick wants to merge 1 commit into
Open
Conversation
Separate audio management logic from UI code for better maintainability and single responsibility principle. Changes: - Create AudioController.kt to encapsulate all AudioManager and LoudnessEnhancer logic - Move audio methods from ActivityMain to AudioController: - setInitialVolume() - applyBoost(level: Int) - applyVolume(level: Int) - restartAudioPlayback() - getOutputDeviceInfo() - release() - Update ActivityMain to delegate audio operations to AudioController - Preserve all existing logic, formatting, and behavior Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
codingWiz-rick
force-pushed
the
refactor-audio-logic-from-the-ui-logic
branch
from
af21ca0 to
e17172b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Refactor
ActivityMainto improve code organization and maintainability by separating audio logic from UI code following the Single Responsibility Principle.Changes Made
New File
AudioController.kt* - Encapsulates all audio management logic
setInitialVolume()applyBoost(level: Int)applyVolume(level: Int)restartAudioPlayback()(preserves 8-keyevent sequence)getOutputDeviceInfo()(preserves formatting)release()Modified File
ActivityMain.kt - Now focuses solely on UI and user interactions
audioController = AudioController(this)Testing Checklist