Make Locations Hyperlinks#150
Merged
Merged
Conversation
|
🚀 Expo preview is ready!
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make event “Location” fields behave like hyperlinks by rendering them via Markdown and routing link taps through the app’s openURL() helper, while removing the prior “open in maps” utility approach.
Changes:
- Removed
maybeOpenURL()andopenInMaps()utilities fromsrc/utils/index.js. - Replaced “tap location to open maps” interactions with
react-native-markdown-displayrendering forlocationon the opportunity detail and signup form screens. - Updated Markdown link handling on the opportunity screen’s description to use the standardized
openURL()helper.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/utils/index.js | Removes URL/map helper functions and updates the utilities header comment (currently inconsistent with exports). |
| src/screens/VolunteerOpportunityScreen.js | Renders location with Markdown and routes link presses through openURL(). |
| src/screens/VolunteerFormScreen.js | Renders location with Markdown and routes link presses through openURL(). |
| src/components/VolunteerOpportunity.js | Renders location with Markdown in the opportunity preview card. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.